Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(36)

Issue 1156283002: Remove a Blink left-over of "gcm_user_visible_only". (Closed)

Created:
4 years, 11 months ago by Peter Beverloo
Modified:
4 years, 11 months ago
Reviewers:
johnme
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove a Blink left-over of "gcm_user_visible_only". Support has been removed per the following CL. All consumers will now have to use the PushSubscriptionOptions dictionary. https://codereview.chromium.org/1158923002/ BUG=471534 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/http/tests/push_messaging/resources/push_manifest.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Beverloo
4 years, 11 months ago (2015-05-27 13:03:15 UTC) #2
johnme
lgtm
4 years, 11 months ago (2015-05-28 11:01:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156283002/1
4 years, 11 months ago (2015-06-02 15:59:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64461)
4 years, 11 months ago (2015-06-02 17:11:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156283002/1
4 years, 11 months ago (2015-06-02 17:15:17 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 19:06:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196337

Powered by Google App Engine
This is Rietveld 408576698