Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: lib/runtime/dart/_js_helper.js

Issue 1156273010: fixes browser/runtime_test, and a few extension member fixes (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: merged & format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_internal.js ('k') | lib/runtime/dart/_native_typed_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_js_helper.js
diff --git a/lib/runtime/dart/_js_helper.js b/lib/runtime/dart/_js_helper.js
index 528fdd52d696646b105ed512e31c00cbba5c535a..8bf27ddcc72f72842fca5132a6e9dbe682f3211b 100644
--- a/lib/runtime/dart/_js_helper.js
+++ b/lib/runtime/dart/_js_helper.js
@@ -187,7 +187,6 @@ var _foreign_helper = dart.import(_foreign_helper);
}
}
JSSyntaxRegExp[dart.implements] = () => [core.RegExp];
- dart.defineExtensionMembers(JSSyntaxRegExp, ['allMatches', 'matchAsPrefix']);
dart.setSignature(JSSyntaxRegExp, {
constructors: () => ({JSSyntaxRegExp: [JSSyntaxRegExp, [core.String], {multiLine: core.bool, caseSensitive: core.bool}]}),
methods: () => ({
@@ -202,6 +201,7 @@ var _foreign_helper = dart.import(_foreign_helper);
statics: () => ({makeNative: [core.Object, [core.String, core.bool, core.bool, core.bool]]}),
names: ['makeNative']
});
+ dart.defineExtensionMembers(JSSyntaxRegExp, ['allMatches', 'matchAsPrefix']);
let _match = Symbol('_match');
class _MatchImplementation extends core.Object {
_MatchImplementation(pattern, match) {
@@ -262,6 +262,7 @@ var _foreign_helper = dart.import(_foreign_helper);
dart.setSignature(_AllMatchesIterable, {
constructors: () => ({_AllMatchesIterable: [_AllMatchesIterable, [JSSyntaxRegExp, core.String, core.int]]})
});
+ dart.defineExtensionMembers(_AllMatchesIterable, ['iterator']);
let _regExp = Symbol('_regExp');
let _nextIndex = Symbol('_nextIndex');
let _current = Symbol('_current');
« no previous file with comments | « lib/runtime/dart/_internal.js ('k') | lib/runtime/dart/_native_typed_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698