Chromium Code Reviews
|
|
|
Created:
4 years, 11 months ago by esprehn Modified:
4 years, 10 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionAdd assert that updateLayoutTree clears dirty bits.
We should never leave any dirty bits for style invalidation or style recalc
after having run updateLayoutTree. This adds a tree walk that makes sure all
bits are cleared.
BUG=492730
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197435
Patch Set 1 #Patch Set 2 : Clear more bits. #Patch Set 3 : Better. #Patch Set 4 : Try again. #Patch Set 5 : Fix shadow roots. #Patch Set 6 : Fix animations. #Patch Set 7 : Change assert for documentElement. #Patch Set 8 : Fix build and clean up. #Patch Set 9 : Check the accept conditions for documents. #
Total comments: 1
Patch Set 10 : Just asserts?? #
Total comments: 1
Patch Set 11 : Add a comment. #Messages
Total messages: 47 (20 generated)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
Lots of unit test failures: [ RUN ] AffectedByFocusTest.AffectedByFocusUpdate ASSERTION FAILED: !node.childNeedsStyleRecalc() ../../third_party/WebKit/Source/core/dom/Document.cpp(1698) : void blink::assertLayoutTreeUpdated(blink::Node &) 1 0x10be50d4f blink::Document::updateLayoutTree(blink::StyleRecalcChange) 2 0x10c3cbf6f blink::FrameView::updateLayoutAndStyleIfNeededRecursive() 3 0x10c3cbc1b blink::FrameView::updateLayoutAndStyleForPaintingInternal() 4 0x10a76a0aa (anonymous namespace)::AffectedByFocusTest::setHtmlInnerHTML(char const*) 5 0x10a76b204 (anonymous namespace)::AffectedByFocusTest_AffectedByFocusUpdate_Test::TestBody() 6 0x10ad08162 testing::Test::Run()
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
Alright now up to layout tests: virtual/threaded/animations/display-none-cancels-nested-animations.html fast/parser/append-child-followed-by-document-write.html animations/display-none-cancels-nested-animations.html fast/dom/shadow/shadow-disable.html http/tests/serviceworker/skip-waiting-using-registration.html fast/animation/animation-without-parent-crash.html
Is this part of a larger work or just a one-off thing? Sounds exciting, would love to track the bug.
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/56639)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/160001
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
https://codereview.chromium.org/1156273002/diff/160001/Source/core/html/parse... File Source/core/html/parser/HTMLConstructionSite.cpp (right): https://codereview.chromium.org/1156273002/diff/160001/Source/core/html/parse... Source/core/html/parser/HTMLConstructionSite.cpp:109: } This change lg tm. Would you like to split this up to separate CL for landing?
Yup that's the plan. :) To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Okay next is inspector/elements/animation-timeline.html which fails with !node.needsDistributionRecalc(), but apparently not on mac??
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
esprehn@chromium.org changed reviewers: + timloh@chromium.org
I think it's only accessibility/add-to-menu-list-crashes.html now and that crashes only on windows and linux for some strange reason. Unfortunately you don't get a stack trace on those bots.
On 2015/06/03 at 08:34:52, esprehn wrote: > I think it's only accessibility/add-to-menu-list-crashes.html now and that crashes only on windows and linux for some strange reason. Unfortunately you don't get a stack trace on those bots. Filed as http://crbug.com/497953 it might happen on OS X with that test case too.
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/180001
esprehn@chromium.org changed reviewers: + dglazkov@chromium.org, ojan@chromium.org - kouhei@chromium.org
lgtm https://codereview.chromium.org/1156273002/diff/180001/Source/core/dom/Docume... File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/1156273002/diff/180001/Source/core/dom/Docume... Source/core/dom/Document.cpp:1691: // matter like Comment and ProcessingInstruction nodes. Add a FIXME to not dirty these in the first place?
The CQ bit was checked by esprehn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ojan@chromium.org Link to the patchset: https://codereview.chromium.org/1156273002/#ps200001 (title: "Add a comment.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59686)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156273002/200001
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197435 |
