Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156253004: Fix URLs and queries in prober and alerts (Closed)

Created:
5 years, 6 months ago by stephana
Modified:
5 years, 6 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M alertserver/alerts.cfg View 1 3 chunks +14 lines, -4 lines 0 comments Download
M prober/probers.json View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stephana
5 years, 6 months ago (2015-06-01 16:41:51 UTC) #2
jcgregorio
https://codereview.chromium.org/1156253004/diff/1/prober/probers.json File prober/probers.json (right): https://codereview.chromium.org/1156253004/diff/1/prober/probers.json#newcode39 prober/probers.json:39: "skiagold-hashes": { Are you going to add an alert ...
5 years, 6 months ago (2015-06-01 16:43:52 UTC) #3
stephana
https://codereview.chromium.org/1156253004/diff/1/prober/probers.json File prober/probers.json (right): https://codereview.chromium.org/1156253004/diff/1/prober/probers.json#newcode39 prober/probers.json:39: "skiagold-hashes": { On 2015/06/01 16:43:52, jcgregorio wrote: > Are ...
5 years, 6 months ago (2015-06-01 17:07:41 UTC) #4
jcgregorio
lgtm
5 years, 6 months ago (2015-06-01 17:22:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156253004/20001
5 years, 6 months ago (2015-06-01 17:27:56 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 17:29:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/fce685dd41a797fea0df1c6b6d21c9054878...

Powered by Google App Engine
This is Rietveld 408576698