Issue 1156243002: Delete WebPluginScrollbar and friends

Issue 1156243002: Delete WebPluginScrollbar and friends (Closed)

Created:
5 years, 7 months ago by raymes

Modified:
5 years, 6 months ago

Reviewers:
dcheng

CC:
dcheng, blink-reviews, chrome-apps-syd-reviews_chromium.org, dglazkov+blink, mlamouri+watch-blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Delete WebPluginScrollbar and friends This removes WebPluginScrollbar which is no longer used in chromium after https://codereview.chromium.org/1161563002/ BUG=303491 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196119

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -1050 lines)			Patch
D	Source/web/ScrollbarGroup.h	View	1 chunk	+0 lines, -85 lines	0 comments	Download
D	Source/web/ScrollbarGroup.cpp	View	1 chunk	+0 lines, -279 lines	0 comments	Download
M	Source/web/WebFrameWidgetImpl.cpp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.cpp	View	7 chunks	+0 lines, -54 lines	0 comments	Download
D	Source/web/WebPluginScrollbarImpl.h	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	Source/web/WebPluginScrollbarImpl.cpp	View	1 chunk	+0 lines, -376 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	Source/web/web.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	public/web/WebPluginScrollbar.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	public/web/WebPluginScrollbarClient.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download

Total messages: 8 (2 generated)

dcheng

The change seems fine, but I don't see any references to WebPluginScrollbar.h in the patch ...

5 years, 7 months ago (2015-05-27 04:45:20 UTC) #3

raymes

On 2015/05/27 04:45:20, dcheng wrote: > The change seems fine, but I don't see any ...

5 years, 7 months ago (2015-05-27 04:47:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156243002/1

5 years, 6 months ago (2015-05-29 03:00:25 UTC) #7

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 04:11:39 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196119