Added message when upstream branch is gone.

Added message when upstream branch is gone.

BUG=496892
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295634

[pgervais, 2015-06-08 17:56:04]

pgervais@chromium.org changed reviewers:
+ iannucci@chromium.org

[pgervais, 2015-06-08 17:56:05]

Added a more helpful message for users in git cl upload.
Tests are all broken now because they're testing implementation. I'll fix them
while you review.

[iannucci, 2015-06-08 18:01:56]

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py
File git_cl.py (left):

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py#oldcode722
git_cl.py:722: self.GetUpstreamBranch())
why not have GetUpstreamBranch do this check?

[pgervais, 2015-06-08 20:48:16]

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py
File git_cl.py (left):

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py#oldcode722
git_cl.py:722: self.GetUpstreamBranch())
On 2015/06/08 18:01:56, iannucci wrote:
> why not have GetUpstreamBranch do this check?

I wasn't sure it wouldn't break something else, like rebase-update.

[pgervais, 2015-06-08 22:23:13]

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py
File git_cl.py (left):

https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py#oldcode722
git_cl.py:722: self.GetUpstreamBranch())
On 2015/06/08 20:48:16, pgervais wrote:
> On 2015/06/08 18:01:56, iannucci wrote:
> > why not have GetUpstreamBranch do this check?
> 
> I wasn't sure it wouldn't break something else, like rebase-update.

Well, it would break CMDupstream, when it's used to print the name of the
upstream branch. We want to print it even when it doesn't exist anymore.

[pgervais, 2015-06-09 22:43:09]

On 2015/06/08 22:23:13, pgervais wrote:
> https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py
> File git_cl.py (left):
> 
> https://chromiumcodereview.appspot.com/1156223008/diff/1/git_cl.py#oldcode722
> git_cl.py:722: self.GetUpstreamBranch())
> On 2015/06/08 20:48:16, pgervais wrote:
> > On 2015/06/08 18:01:56, iannucci wrote:
> > > why not have GetUpstreamBranch do this check?
> > 
> > I wasn't sure it wouldn't break something else, like rebase-update.
> 
> Well, it would break CMDupstream, when it's used to print the name of the
> upstream branch. We want to print it even when it doesn't exist anymore.

ping

[iannucci, 2015-06-11 19:44:32]

lgtm

[pgervais, 2015-06-11 19:45:06]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2015-06-11 19:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156223008/1

[commit-bot: I haz the power, 2015-06-11 19:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 19:51:39]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[pgervais, 2015-06-11 21:38:01]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2015-06-11 21:38:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1156223008/#ps20001
(title: "Fixed tests")

[commit-bot: I haz the power, 2015-06-11 21:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156223008/20001

[commit-bot: I haz the power, 2015-06-11 21:41:27]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295634