Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 1156223005: Remove AnalysisContext.visibleLibraries getter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix LibraryElement.visibleLibraries tests with NTM. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/context/context_test.dart
diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart
index 02765e8c3b18904bc04b927138b669f10951a546..71040cab47f4055d2e09140448c02ad87222ef76 100644
--- a/pkg/analyzer/test/src/context/context_test.dart
+++ b/pkg/analyzer/test/src/context/context_test.dart
@@ -807,7 +807,7 @@ void g() { f(null); }''');
fail("Implement this");
}
- void fail_resolveCompilationUnit_import_relative() {
+ void test_resolveCompilationUnit_import_relative() {
Source sourceA =
addSource("/libA.dart", "library libA; import 'libB.dart'; class A{}");
addSource("/libB.dart", "library libB; class B{}");
@@ -818,10 +818,16 @@ void g() { f(null); }''');
List<LibraryElement> importedLibraries = library.importedLibraries;
assertNamedElements(importedLibraries, ["dart.core", "libB"]);
List<LibraryElement> visibleLibraries = library.visibleLibraries;
- assertNamedElements(visibleLibraries, ["dart.core", "libA", "libB"]);
+ assertNamedElements(visibleLibraries, [
+ "dart.core",
+ "dart.async",
+ "dart.math",
+ "libA",
+ "libB"
+ ]);
}
- void fail_resolveCompilationUnit_import_relative_cyclic() {
+ void test_resolveCompilationUnit_import_relative_cyclic() {
Source sourceA =
addSource("/libA.dart", "library libA; import 'libB.dart'; class A{}");
addSource("/libB.dart", "library libB; import 'libA.dart'; class B{}");
@@ -832,7 +838,13 @@ void g() { f(null); }''');
List<LibraryElement> importedLibraries = library.importedLibraries;
assertNamedElements(importedLibraries, ["dart.core", "libB"]);
List<LibraryElement> visibleLibraries = library.visibleLibraries;
- assertNamedElements(visibleLibraries, ["dart.core", "libA", "libB"]);
+ assertNamedElements(visibleLibraries, [
+ "dart.core",
+ "dart.async",
+ "dart.math",
+ "libA",
+ "libB"
+ ]);
}
void fail_resolveHtmlUnit() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698