Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1156183004: Make x32 compile with gcc. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make x32 compile with gcc. BUG=chromium:430032 LOG=n Committed: https://crrev.com/03f4ddb1f2d51287206030fd684e4b29a906f6f2 Cr-Commit-Position: refs/heads/master@{#28821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-07 18:30:47 UTC) #2
haitao.feng
LGTM.
5 years, 6 months ago (2015-06-08 01:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156183004/1
5 years, 6 months ago (2015-06-08 06:47:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 07:14:41 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 07:14:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03f4ddb1f2d51287206030fd684e4b29a906f6f2
Cr-Commit-Position: refs/heads/master@{#28821}

Powered by Google App Engine
This is Rietveld 408576698