Pass file Regions along with FDs to child processes on Android

base/files/memory_mapped_file.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/memory_mapped_file.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/sys_info.h"
 
 namespace base {
 
 const MemoryMappedFile::Region MemoryMappedFile::Region::kWholeFile(
     base::LINKER_INITIALIZED);
 
 MemoryMappedFile::Region::Region(base::LinkerInitialized) : offset(0), size(0) {
 }
 
+MemoryMappedFile::Region::Region() : offset(-1), size(-1) {
+}
+
 MemoryMappedFile::Region::Region(int64 offset, int64 size)
     : offset(offset), size(size) {
-  DCHECK_GE(offset, 0);
-  DCHECK_GT(size, 0);
 }
 
 bool MemoryMappedFile::Region::operator==(
     const MemoryMappedFile::Region& other) const {
   return other.offset == offset && other.size == size;
 }
 
 MemoryMappedFile::~MemoryMappedFile() {
   CloseHandles();
 }
@@ skipping 19 matching lines @@
 }
 
 bool MemoryMappedFile::Initialize(File file) {
   return Initialize(file.Pass(), Region::kWholeFile);
 }
 
 bool MemoryMappedFile::Initialize(File file, const Region& region) {
   if (IsValid())
     return false;
 
+  if (!(region == Region::kWholeFile)) {

[Lei Zhang, 2015/06/02 18:59:11]

should we implement operator!= ?

[agrieve, 2015/06/02 19:21:38]

Seems reasonable doesn't it? :) Done!

+    DCHECK_GE(region.offset, 0);
+    DCHECK_GT(region.size, 0);
+  }
+
   file_ = file.Pass();
 
   if (!MapFileRegionToMemory(region)) {
     CloseHandles();
     return false;
   }
 
   return true;
 }
 
@@ skipping 10 matching lines @@
   // Sadly, on Windows, the mmap alignment is not just equal to the page size.
   const int64 mask = static_cast<int64>(SysInfo::VMAllocationGranularity()) - 1;
   DCHECK_LT(mask, std::numeric_limits<int32>::max());
   *offset = start & mask;
   *aligned_start = start & ~mask;
   *aligned_size = (size + *offset + mask) & ~mask;
 }
 #endif
 
 }  // namespace base