Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: runtime/vm/isolate.cc

Issue 1156183002: privatize and remove some fields in Isolate response (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_isolate_rpc_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index d0fa2bf580b75618591044edf97f09ca804cfb51..9b64c07e5a62417a855ed0d8cf4a3adeeb4d6df1 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1512,7 +1512,7 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
}
}
{
- JSONObject jsheap(&jsobj, "heaps");
+ JSONObject jsheap(&jsobj, "_heaps");
heap()->PrintToJSONObject(Heap::kNew, &jsheap);
heap()->PrintToJSONObject(Heap::kOld, &jsheap);
}
@@ -1548,7 +1548,7 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
timer_list().PrintTimersToJSONProperty(&jsobj);
{
- JSONObject tagCounters(&jsobj, "tagCounters");
+ JSONObject tagCounters(&jsobj, "_tagCounters");
vm_tag_counters()->PrintToJSONObject(&tagCounters);
}
if (object_store()->sticky_error() != Object::null()) {
@@ -1557,21 +1557,15 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
jsobj.AddProperty("error", error, false);
}
- bool is_io_enabled = false;
{
const GrowableObjectArray& libs =
GrowableObjectArray::Handle(object_store()->libraries());
intptr_t num_libs = libs.Length();
Library& lib = Library::Handle();
- String& name = String::Handle();
JSONArray lib_array(&jsobj, "libraries");
for (intptr_t i = 0; i < num_libs; i++) {
lib ^= libs.At(i);
- name = lib.name();
- if (name.Equals(Symbols::DartIOLibName())) {
- is_io_enabled = true;
- }
ASSERT(!lib.IsNull());
lib_array.AddValue(lib);
}
@@ -1580,12 +1574,6 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
JSONArray breakpoints(&jsobj, "breakpoints");
debugger()->PrintBreakpointsToJSONArray(&breakpoints);
}
- {
- JSONArray features_array(&jsobj, "features");
- if (is_io_enabled) {
- features_array.AddValue("io");
- }
- }
}
« no previous file with comments | « runtime/observatory/tests/service/get_isolate_rpc_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698