Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1156183002: privatize and remove some fields in Isolate response (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_isolate_rpc_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index e9f9b867f92afc7cff97b58c20a65203b85eff61..417ad70a088efa4377c4ba21797fe64a87ab59bc 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -994,12 +994,6 @@ class Isolate extends ServiceObjectOwner with Coverage {
loading = false;
_upgradeCollection(map, isolate);
- if (map['rootLib'] == null ||
- map['timers'] == null ||
- map['heaps'] == null) {
- Logger.root.severe("Malformed 'Isolate' response: $map");
- return;
- }
rootLibrary = map['rootLib'];
if (map['entry'] != null) {
entry = map['entry'];
@@ -1007,7 +1001,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
var startTimeInMillis = map['startTime'];
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeInMillis);
notifyPropertyChange(#upTime, 0, 1);
- var countersMap = map['tagCounters'];
+ var countersMap = map['_tagCounters'];
if (countersMap != null) {
var names = countersMap['names'];
var counts = countersMap['counters'];
@@ -1042,17 +1036,9 @@ class Isolate extends ServiceObjectOwner with Coverage {
timerMap['time_bootstrap']);
timers['dart'] = timerMap['time_dart_execution'];
- updateHeapsFromMap(map['heaps']);
+ updateHeapsFromMap(map['_heaps']);
_updateBreakpoints(map['breakpoints']);
- List features = map['features'];
- if (features != null) {
- for (var feature in features) {
- if (feature == 'io') {
- ioEnabled = true;
- }
- }
- }
pauseEvent = map['pauseEvent'];
_updateRunState();
error = map['error'];
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_isolate_rpc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698