talk/app/webrtc/peerconnectioninterface.h - Issue 1156143005: Report metrics about negotiated ciphers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1156143005: Report metrics about negotiated ciphers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Overload "AddHistogramSample" to store metrics. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/peerconnectioninterface.h

diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h

index 3e4cb556fb5f51826734c719a5cf3f6e46bc36e8..08df6d6699392bc980d720012ad711147e553768 100644

--- a/talk/app/webrtc/peerconnectioninterface.h

+++ b/talk/app/webrtc/peerconnectioninterface.h

@@ -127,6 +127,9 @@ class MetricsObserverInterface : public rtc::RefCountInterface {

virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;

virtual void AddHistogramSample(PeerConnectionMetricsName type,

int value) = 0;

+ // TODO(jbauch): Make method abstract when it is implemented by Chromium.

+ virtual void AddHistogramSample(PeerConnectionMetricsName type,

+ const std::string& value) {};

tommi 2015/06/30 12:42:51 remove semicolon

joachim 2015/06/30 16:06:38 Done.

protected:

virtual ~MetricsObserverInterface() {}

« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/umametrics.h » ('j') | no next file with comments »