Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: talk/app/webrtc/fakemetricsobserver.h

Issue 1156143005: Report metrics about negotiated ciphers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Overload "AddHistogramSample" to store metrics. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
11 * this list of conditions and the following disclaimer in the documentation 11 * this list of conditions and the following disclaimer in the documentation
12 * and/or other materials provided with the distribution. 12 * and/or other materials provided with the distribution.
13 * 3. The name of the author may not be used to endorse or promote products 13 * 3. The name of the author may not be used to endorse or promote products
14 * derived from this software without specific prior written permission. 14 * derived from this software without specific prior written permission.
15 * 15 *
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO 18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #ifndef TALK_APP_WEBRTC_DTLSIDENTITYSERVICE_H_ 28 #ifndef TALK_APP_WEBRTC_FAKEMETRICSOBSERVER_H_
29 #define TALK_APP_WEBRTC_DTLSIDENTITYSERVICE_H_ 29 #define TALK_APP_WEBRTC_FAKEMETRICSOBSERVER_H_
30 30
31 #include <map>
31 #include <string> 32 #include <string>
32 33
33 #include "talk/app/webrtc/peerconnectioninterface.h" 34 #include "talk/app/webrtc/peerconnectioninterface.h"
34 35
35 namespace webrtc { 36 namespace webrtc {
36 37
37 class DtlsIdentityStore; 38 class FakeMetricsObserver : public MetricsObserverInterface {
39 public:
40 FakeMetricsObserver() { Reset(); }
41 void Reset() {
42 memset(peer_connection_metrics_counters_, 0,
43 sizeof(peer_connection_metrics_counters_));
44 memset(peer_connection_metrics_name_, 0,
45 sizeof(peer_connection_metrics_name_));
46 for (std::string& type : peer_connection_metrics_name_string_) {
47 type.clear();
48 }
49 }
38 50
39 // This class forwards the request to DtlsIdentityStore to generate the 51 void IncrementCounter(PeerConnectionMetricsCounter type) override {
40 // identity. 52 peer_connection_metrics_counters_[type]++;
41 class DtlsIdentityService : public webrtc::DTLSIdentityServiceInterface { 53 }
42 public: 54 void AddHistogramSample(PeerConnectionMetricsName type,
43 explicit DtlsIdentityService(DtlsIdentityStore* store) : store_(store) {} 55 int value) override {
56 ASSERT(peer_connection_metrics_name_[type] == 0);
57 peer_connection_metrics_name_[type] = value;
58 }
59 void AddHistogramSample(PeerConnectionMetricsName type,
60 const std::string& value) override {
61 peer_connection_metrics_name_string_[type] = value;
62 }
44 63
45 // DTLSIdentityServiceInterface impl. 64 int peer_connection_metrics_counters_
46 // |identity_name| and |common_name| must equal to 65 [kPeerConnectionMetricsCounter_Max];
47 // DtlsIdentityStore::kIdentityName, otherwise the request will fail and false 66 int peer_connection_metrics_name_[kPeerConnectionMetricsCounter_Max];
48 // will be returned. 67 std::string peer_connection_metrics_name_string_
49 bool RequestIdentity(const std::string& identity_name, 68 [kPeerConnectionMetricsName_Max];
50 const std::string& common_name,
51 webrtc::DTLSIdentityRequestObserver* observer) override;
52 69
53 private: 70 int AddRef() override { return 1; }
54 DtlsIdentityStore* store_; 71 int Release() override { return 1; }
55 }; 72 };
56 73
57 } // namespace webrtc 74 } // namespace webrtc
58 75
59 #endif // TALK_APP_WEBRTC_DTLSIDENTITYSERVICE_H_ 76 #endif // TALK_APP_WEBRTC_FAKEMETRICSOBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/peerconnection_unittest.cc » ('j') | talk/app/webrtc/peerconnectioninterface.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698