runtime/vm/runtime_entry.h - Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/runtime_entry.h

Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix comment; remove unused accessor. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/runtime_entry.h

diff --git a/runtime/vm/runtime_entry.h b/runtime/vm/runtime_entry.h

index f0580a683041f40ad7b77166c261dd9d5dfa3614..27c9619e6ec2d83f2e55d8acda3a51501927bf62 100644

--- a/runtime/vm/runtime_entry.h

+++ b/runtime/vm/runtime_entry.h

@@ -77,9 +77,9 @@ class RuntimeEntry : public ValueObject {

ASSERT(arguments.ArgCount() == argument_count); \

if (FLAG_trace_runtime_calls) OS::Print("Runtime call: %s\n", ""#name); \

{ \

- Isolate* isolate = arguments.isolate(); \

- Thread* thread = isolate->mutator_thread(); \

+ Thread* thread = arguments.thread(); \

ASSERT(thread == Thread::Current()); \

+ Isolate* isolate = thread->isolate(); \

StackZone zone(isolate); \

HANDLESCOPE(isolate); \

DRT_Helper##name(isolate, thread, zone.GetZone(), arguments); \

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service_isolate.cc » ('j') | no next file with comments »