Source/core/layout/LayoutTableSection.cpp - Issue 1156143002: *** NOT FOR LANDING *** Text nodes should only inherit inheritable properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1156143002: *** NOT FOR LANDING *** Text nodes should only inherit inheritable properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Some tests need to be rebaselined. Text nodes can no longer have z-index. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutTableSection.cpp

diff --git a/Source/core/layout/LayoutTableSection.cpp b/Source/core/layout/LayoutTableSection.cpp

index 34c709e8ef2d19ebda472fe4f9cfa77750ce14db..3a1e4210db4b0e5236468d7d51ccc3520fbe89db 100644

--- a/Source/core/layout/LayoutTableSection.cpp

+++ b/Source/core/layout/LayoutTableSection.cpp

@@ -997,7 +997,7 @@ void LayoutTableSection::layoutRows()

|| (!table()->style()->logicalHeight().isAuto() && rHeight != cell->logicalHeight());

for (LayoutObject* child = cell->firstChild(); child; child = child->nextSibling()) {

- if (!child->isText() && child->style()->logicalHeight().hasPercent()

+ if (child->style()->logicalHeight().hasPercent()

&& (flexAllChildren || shouldFlexCellChild(child))

&& (!child->isTable() || toLayoutTable(child)->hasSections())) {

cellChildrenFlex = true;

« Source/core/dom/LayoutTreeBuilder.cpp ('K') | « Source/core/layout/LayoutQuote.cpp ('k') | Source/core/layout/LayoutText.cpp » ('j') | Source/core/layout/LayoutText.cpp » ('J')