Source/core/css/resolver/StyleResolver.cpp - Issue 1156143002: *** NOT FOR LANDING *** Text nodes should only inherit inheritable properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 1156143002: *** NOT FOR LANDING *** Text nodes should only inherit inheritable properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Some tests need to be rebaselined. Text nodes can no longer have z-index. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleResolver.cpp

diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp

index 6a3b2ac47f325aae8c9a7622a86f31013bde7b99..4d133423fba79219410c2fa05b99da5b2a32415d 100644

--- a/Source/core/css/resolver/StyleResolver.cpp

+++ b/Source/core/css/resolver/StyleResolver.cpp

@@ -898,7 +898,7 @@ PassRefPtr<ComputedStyle> StyleResolver::styleForText(Text* textNode)

Node* parentNode = LayoutTreeBuilderTraversal::parent(*textNode);

if (!parentNode || !parentNode->computedStyle())

return initialStyleForElement();

- return parentNode->mutableComputedStyle();

+ return ComputedStyle::createWithInheritableProperties(parentNode->computedStyleRef());

}

void StyleResolver::updateFont(StyleResolverState& state)

« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/dom/FirstLetterPseudoElement.cpp » ('j') | Source/core/dom/LayoutTreeBuilder.cpp » ('J')