Issue 115613002: Remove src_base remapping in AddPyAutoFunctionalTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115613002: Remove src_base remapping in AddPyAutoFunctionalTest. (Closed)

Created:
7 years ago by Nico

Modified:
7 years ago

Reviewers:
ghost stip (do not use)

CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

Remove src_base remapping in AddPyAutoFunctionalTest. AddPyAutoFunctionalTest is only called from AddMediaTests, which doesn't pass a src_base parameter, so the default value '.' is used. Making something relative to '.' doesn't change its meaning. No intended functionality change. BUG=224072, 314253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240808

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
	M	build/scripts/master/factory/chromium_commands.py	View		4 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

(you added this in http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/master/factory/chromium_commands.py?r1=182349&r2=182348&pathrev=182349 apparently. Hopefully, perf_av will go away eventually, then this whole ...

7 years ago (2013-12-13 23:40:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/115613002/1

7 years ago (2013-12-13 23:55:16 UTC) #3

Message was sent while issue was closed.

Change committed as 240808

Expand Messages | Collapse Messages