Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: include/core/SkDevice.h

Issue 1156073003: remove unneeded device:lockpixels (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkBitmapDevice.h ('k') | src/core/SkBitmapDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkDevice.h
diff --git a/include/core/SkDevice.h b/include/core/SkDevice.h
index b474687cfbf0ce4c8fda8ca4a958e59585cc3415..3bdcfcf8a3e8f31e5709aed807630288a796b97c 100644
--- a/include/core/SkDevice.h
+++ b/include/core/SkDevice.h
@@ -104,7 +104,6 @@ public:
*/
virtual void onAttachToCanvas(SkCanvas*) {
SkASSERT(!fAttachedToCanvas);
- this->lockPixels();
#ifdef SK_DEBUG
fAttachedToCanvas = true;
#endif
@@ -118,7 +117,6 @@ public:
*/
virtual void onDetachFromCanvas() {
SkASSERT(fAttachedToCanvas);
- this->unlockPixels();
#ifdef SK_DEBUG
fAttachedToCanvas = false;
#endif
@@ -251,12 +249,6 @@ protected:
*/
virtual const SkBitmap& onAccessBitmap() = 0;
- /** Called when this device is installed into a Canvas. Balanced by a call
- to unlockPixels() when the device is removed from a Canvas.
- */
- virtual void lockPixels() {}
- virtual void unlockPixels() {}
-
/**
* Override and return true for filters that the device can handle
* intrinsically. Doing so means that SkCanvas will pass-through this
« no previous file with comments | « include/core/SkBitmapDevice.h ('k') | src/core/SkBitmapDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698