Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156053002: Move SVGTextChunkBuilder out of SVGTextLayoutEngine (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move SVGTextChunkBuilder out of SVGTextLayoutEngine This member of SVGTextLayoutEngine has a very narrow scope in which it is used. The data produced into it is in practice consumed within the very same method. Hence move it out of class scope and into function scope. Also take the opportunity to move finalizeTransformMatrices() to SVGTextChunkBuilder as well, since it essentially applies data from the latter. Also drop the debug code within DUMP_TEXT_FRAGMENTS. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -76 lines) Patch
M Source/core/layout/svg/SVGTextChunkBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 2 chunks +14 lines, -5 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 4 chunks +10 lines, -67 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 7 months ago (2015-05-25 13:19:24 UTC) #2
pdr.
LGTM
5 years, 7 months ago (2015-05-27 03:30:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156053002/1
5 years, 7 months ago (2015-05-27 07:52:01 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 11:10:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195969

Powered by Google App Engine
This is Rietveld 408576698