Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4413)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.h

Issue 1156043002: chrome.tabs.onUpdated doesn't called with 'loading' twice. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_event_router.h
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.h b/chrome/browser/extensions/api/tabs/tabs_event_router.h
index 45a63c39683fe3b3f86c9ce03bd1479e82adfe4e..a949d889a5419b5c4b1e0264dea2edb4dc3e58d5 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.h
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.h
@@ -14,6 +14,7 @@
#include "chrome/browser/extensions/api/tabs/tabs_api.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
+#include "chrome/common/extensions/api/tabs.h"
#include "components/favicon/core/favicon_driver_observer.h"
#include "components/ui/zoom/zoom_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -94,7 +95,7 @@ class TabsEventRouter : public TabStripModelObserver,
// Internal processing of tab updated events. Is called by both TabChangedAt
// and Observe/NAV_ENTRY_COMMITTED.
- void TabUpdated(content::WebContents* contents, bool did_navigate);
+ void TabUpdated(content::WebContents* contents, api::tabs::TabStatus status);
// Triggers a tab updated event if the favicon URL changes.
void FaviconUrlUpdated(content::WebContents* contents);
@@ -162,6 +163,10 @@ class TabsEventRouter : public TabStripModelObserver,
// should be sent.
base::DictionaryValue* DidNavigate(const content::WebContents* contents);
+ // Update URL without a state-change. Returns NULL if the URL of |contents|
+ // is same with current URL.
+ base::DictionaryValue* UpdateUrl(const content::WebContents* contents);
+
private:
// Whether we are waiting to fire the 'complete' status change. This will
// occur the first time the WebContents stops loading after the

Powered by Google App Engine
This is Rietveld 408576698