Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1156023006: Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized (Closed)

Created:
5 years, 6 months ago by nasko
Modified:
5 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bring RFH/RVH unit tests closer to reality of how RF/RV are initialized This is an attempt at relanding https://codereview.chromium.org/1151973005, which broke official builds due to RlzLibTest unit tests failing. The initial patchset is identical to the previously committed CL and subsequent uploads are changes made to fix the failures. BUG=357747 TEST=all unit tests continue passing Committed: https://crrev.com/8c95dcf5164de33fd42d29567adb24655b4c2ab0 Cr-Commit-Position: refs/heads/master@{#332380}

Patch Set 1 #

Patch Set 2 : Move InitializeRenderFrameIfNeeded to RenderFrameHostTester and fix RlzLibTest code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -28 lines) Patch
M chrome/browser/rlz/rlz_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_render_frame_host.cc View 1 5 chunks +11 lines, -12 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/test_web_contents.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
nasko
Hey Nick, Can you review this CL for me? It fixes the Rlz failure from ...
5 years, 6 months ago (2015-06-01 18:19:07 UTC) #2
ncarter (slow)
lgtm
5 years, 6 months ago (2015-06-01 19:49:08 UTC) #3
mattm
safe_browsing lgtm
5 years, 6 months ago (2015-06-01 21:26:30 UTC) #4
bengr
data_reduction_proxy lgtm
5 years, 6 months ago (2015-06-01 21:49:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156023006/20001
5 years, 6 months ago (2015-06-01 23:36:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 00:59:53 UTC) #9
Roger Tawa OOO till Jul 10th
rlz lgtm
5 years, 6 months ago (2015-06-02 13:37:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156023006/20001
5 years, 6 months ago (2015-06-02 13:41:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 13:44:55 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 13:45:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c95dcf5164de33fd42d29567adb24655b4c2ab0
Cr-Commit-Position: refs/heads/master@{#332380}

Powered by Google App Engine
This is Rietveld 408576698