Decode ImageManager cached images on demand.

components/suggestions/image_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/run_loop.h"
 #include "components/leveldb_proto/proto_database.h"
 #include "components/leveldb_proto/testing/fake_db.h"
 #include "components/suggestions/image_encoder.h"
 #include "components/suggestions/image_fetcher.h"
 #include "components/suggestions/image_fetcher_delegate.h"
 #include "components/suggestions/image_manager.h"
 #include "components/suggestions/proto/suggestions.pb.h"
+#include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
 using ::testing::Return;
 using ::testing::StrictMock;
 using ::testing::_;
+using content::BrowserThread;
 
 namespace suggestions {
 
 const char kTestUrl1[] = "http://go.com/";
 const char kTestUrl2[] = "http://goal.com/";
 const char kTestImagePath[] = "files/image_decoding/droids.png";
 const char kInvalidImagePath[] = "files/DOESNOTEXIST";
 
 using leveldb_proto::test::FakeDB;
 using suggestions::ImageData;
@@ skipping 11 matching lines @@
                void(const GURL&, const GURL&,
                     base::Callback<void(const GURL&, const SkBitmap*)>));
   MOCK_METHOD1(SetImageFetcherDelegate, void(ImageFetcherDelegate*));
 };
 
 class ImageManagerTest : public testing::Test {
  public:
   ImageManagerTest()
       : mock_image_fetcher_(NULL),
         num_callback_null_called_(0),
-        num_callback_valid_called_(0) {}
+        num_callback_valid_called_(0),
+        db_thread_(BrowserThread::DB) {
+    db_thread_.Start();
+  }
 
   void SetUp() override {
     fake_db_ = new FakeDB<ImageData>(&db_model_);
     image_manager_.reset(CreateImageManager(fake_db_));
   }
 
   void TearDown() override {
     fake_db_ = NULL;
     db_model_.clear();
     image_manager_.reset();
@@ skipping 52 matching lines @@
   }
 
   EntryMap db_model_;
   // Owned by the ImageManager under test.
   FakeDB<ImageData>* fake_db_;
 
   MockImageFetcher* mock_image_fetcher_;
 
   int num_callback_null_called_;
   int num_callback_valid_called_;
+
+  base::MessageLoop message_loop_;
+  content::TestBrowserThread db_thread_;
+
   // Under test.
   scoped_ptr<ImageManager> image_manager_;
 };
 
 TEST_F(ImageManagerTest, InitializeTest) {
   SuggestionsProfile suggestions_profile;
   ChromeSuggestion* suggestion = suggestions_profile.add_suggestions();
   suggestion->set_url(kTestUrl1);
   suggestion->set_thumbnail(kTestImagePath);
 
@@ skipping 36 matching lines @@
   suggestion->set_thumbnail(kInvalidImagePath);
 
   // Create the ImageManager with an added entry in the database.
   AddEntry(GetSampleImageData(kTestUrl1), &db_model_);
   FakeDB<ImageData>* fake_db = new FakeDB<ImageData>(&db_model_);
   image_manager_.reset(CreateImageManager(fake_db));
   image_manager_->Initialize(suggestions_profile);
   fake_db->InitCallback(true);
   fake_db->LoadCallback(true);
   // Expect something in the cache.
-  SkBitmap* bitmap = image_manager_->GetBitmapFromCache(GURL(kTestUrl1));
-  EXPECT_FALSE(bitmap->isNull());
+  auto encoded_image =
+      image_manager_->GetEncodedImageFromCache(GURL(kTestUrl1));
+  EXPECT_NE(nullptr, encoded_image);
 
   base::RunLoop run_loop;
   image_manager_->GetImageForURL(GURL(kTestUrl1),
                                  base::Bind(&ImageManagerTest::OnImageAvailable,
                                             base::Unretained(this), &run_loop));
   run_loop.Run();
 
   EXPECT_EQ(0, num_callback_null_called_);
   EXPECT_EQ(1, num_callback_valid_called_);
 }
 
 }  // namespace suggestions