sky/engine/core/loader/ImageLoader.idl - Issue 1156003007: Refactor image handling in Sky

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/loader/ImageLoader.idl

Issue 1156003007: Refactor image handling in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Catch errors in example Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Constructor(),	6 Constructor(),

7 ImplementedAs=CanvasImage,	7 ImplementedAs=CanvasImageLoader,

8 ] interface Image {	8 ] interface ImageLoader {

9 readonly attribute long width;	9 void load(DOMString src, ImageLoaderCallback callback);
	abarth-chromium 2015/06/01 22:57:09 Should ImageLoader support multiple in-flight imag Should ImageLoader support multiple in-flight image loads? The interface looks like it does but the implementation does not... Maybe pass the \|src\| and the \|callback\| as constructor parameters? That way it is clear that each instance can handle only one load. jackson 2015/06/01 23:10:26 Acknowledged. Show quoted text On 2015/06/01 22:57:09, abarth wrote: > Should ImageLoader support multiple in-flight image loads? The interface looks > like it does but the implementation does not... > > Maybe pass the \|src\| and the \|callback\| as constructor parameters? That way it > is clear that each instance can handle only one load. Acknowledged.
10 readonly attribute long height;

11 attribute DOMString src;

12 };	10 };

OLD	NEW