| Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
|
| diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
|
| index 3f4f393ae48e7895b1393cf9acf22875454bbe85..d9f7d3fb6f73d6d7a17fdf8b6a8e892bffe2f8ef 100644
|
| --- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
|
| +++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
|
| @@ -32,6 +32,7 @@
|
| #include "content/public/common/javascript_message_type.h"
|
| #include "content/public/common/url_constants.h"
|
| #include "content/public/common/url_utils.h"
|
| +#include "content/public/test/browser_test_utils.h"
|
| #include "content/public/test/mock_render_process_host.h"
|
| #include "content/public/test/test_notification_tracker.h"
|
| #include "content/test/test_content_browser_client.h"
|
| @@ -120,36 +121,6 @@ class CloseWebContentsDelegate : public WebContentsDelegate {
|
| bool close_called_;
|
| };
|
|
|
| -// This observer keeps track of the last deleted RenderViewHost to avoid
|
| -// accessing it and causing use-after-free condition.
|
| -class RenderViewHostDeletedObserver : public WebContentsObserver {
|
| - public:
|
| - RenderViewHostDeletedObserver(RenderViewHost* rvh)
|
| - : WebContentsObserver(WebContents::FromRenderViewHost(rvh)),
|
| - process_id_(rvh->GetProcess()->GetID()),
|
| - routing_id_(rvh->GetRoutingID()),
|
| - deleted_(false) {
|
| - }
|
| -
|
| - void RenderViewDeleted(RenderViewHost* render_view_host) override {
|
| - if (render_view_host->GetProcess()->GetID() == process_id_ &&
|
| - render_view_host->GetRoutingID() == routing_id_) {
|
| - deleted_ = true;
|
| - }
|
| - }
|
| -
|
| - bool deleted() {
|
| - return deleted_;
|
| - }
|
| -
|
| - private:
|
| - int process_id_;
|
| - int routing_id_;
|
| - bool deleted_;
|
| -
|
| - DISALLOW_COPY_AND_ASSIGN(RenderViewHostDeletedObserver);
|
| -};
|
| -
|
| // This observer keeps track of the last created RenderFrameHost to allow tests
|
| // to ensure that no RenderFrameHost objects are created when not expected.
|
| class RenderFrameHostCreatedObserver : public WebContentsObserver {
|
| @@ -173,36 +144,6 @@ class RenderFrameHostCreatedObserver : public WebContentsObserver {
|
| DISALLOW_COPY_AND_ASSIGN(RenderFrameHostCreatedObserver);
|
| };
|
|
|
| -// This observer keeps track of the last deleted RenderFrameHost to avoid
|
| -// accessing it and causing use-after-free condition.
|
| -class RenderFrameHostDeletedObserver : public WebContentsObserver {
|
| - public:
|
| - RenderFrameHostDeletedObserver(RenderFrameHost* rfh)
|
| - : WebContentsObserver(WebContents::FromRenderFrameHost(rfh)),
|
| - process_id_(rfh->GetProcess()->GetID()),
|
| - routing_id_(rfh->GetRoutingID()),
|
| - deleted_(false) {
|
| - }
|
| -
|
| - void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
|
| - if (render_frame_host->GetProcess()->GetID() == process_id_ &&
|
| - render_frame_host->GetRoutingID() == routing_id_) {
|
| - deleted_ = true;
|
| - }
|
| - }
|
| -
|
| - bool deleted() {
|
| - return deleted_;
|
| - }
|
| -
|
| - private:
|
| - int process_id_;
|
| - int routing_id_;
|
| - bool deleted_;
|
| -
|
| - DISALLOW_COPY_AND_ASSIGN(RenderFrameHostDeletedObserver);
|
| -};
|
| -
|
| // This WebContents observer keep track of its RVH change.
|
| class RenderViewHostChangedObserver : public WebContentsObserver {
|
| public:
|
|
|