Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155973004: Add explicit casts from size_t to uint32_t (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
Reviewers:
azani, viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add explicit casts from size_t to uint32_t x64 MSVC is unhappy with the implict conversions. R=viettrungluu@chromium.org, azani@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/4caa6675fc971e670cf72d1c3c44672b707415d6

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M mojo/public/cpp/bindings/tests/union_unittest.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ken Rockot(use gerrit already)
5 years, 6 months ago (2015-06-02 22:20:45 UTC) #1
viettrungluu
Your bots are very red. https://codereview.chromium.org/1155973004/diff/1/mojo/public/cpp/bindings/tests/union_unittest.cc File mojo/public/cpp/bindings/tests/union_unittest.cc (right): https://codereview.chromium.org/1155973004/diff/1/mojo/public/cpp/bindings/tests/union_unittest.cc#newcode522 mojo/public/cpp/bindings/tests/union_unittest.cc:522: void* raw_buf = buf.Leak()); ...
5 years, 6 months ago (2015-06-02 22:45:58 UTC) #3
Ken Rockot(use gerrit already)
fixed >.> https://codereview.chromium.org/1155973004/diff/1/mojo/public/cpp/bindings/tests/union_unittest.cc File mojo/public/cpp/bindings/tests/union_unittest.cc (right): https://codereview.chromium.org/1155973004/diff/1/mojo/public/cpp/bindings/tests/union_unittest.cc#newcode522 mojo/public/cpp/bindings/tests/union_unittest.cc:522: void* raw_buf = buf.Leak()); On 2015/06/02 22:45:57, ...
5 years, 6 months ago (2015-06-02 22:49:40 UTC) #4
viettrungluu
LGTM, assuming green-ish bots.
5 years, 6 months ago (2015-06-02 22:55:16 UTC) #5
Ken Rockot(use gerrit already)
5 years, 6 months ago (2015-06-02 23:17:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4caa6675fc971e670cf72d1c3c44672b707415d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698