Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1155973003: win: Another attempted fix for toolchain/src skew (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
Sorry, this is not going very smoothly.
5 years, 6 months ago (2015-06-02 21:23:25 UTC) #1
davidben
(FWIW, I've already synced BoringSSL's vs_toolchain.py with Chromium's, so our bots shouldn't be sensitive to ...
5 years, 6 months ago (2015-06-02 21:24:46 UTC) #2
Sébastien Marchand
lgtm
5 years, 6 months ago (2015-06-02 21:25:53 UTC) #3
scottmg
On 2015/06/02 21:24:46, David Benjamin wrote: > (FWIW, I've already synced BoringSSL's vs_toolchain.py with Chromium's, ...
5 years, 6 months ago (2015-06-02 21:27:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155973003/1
5 years, 6 months ago (2015-06-02 21:28:25 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 21:31:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295498

Powered by Google App Engine
This is Rietveld 408576698