Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1155963005: DevTools: Show frame rate on timeline events overview. (Closed)

Created:
4 years, 11 months ago by alph
Modified:
4 years, 11 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Show frame rate on timeline events overview. It is put behind an experiment. BUG=497031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196569

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 5 chunks +52 lines, -4 lines 2 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 11 months ago (2015-06-05 07:48:33 UTC) #2
yurys
lgtm https://codereview.chromium.org/1155963005/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1155963005/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode282 Source/devtools/front_end/timeline/TimelineEventOverview.js:282: y = 0.5 + Math.round(baseY - visualHeight * ...
4 years, 11 months ago (2015-06-05 08:26:29 UTC) #4
alph
https://codereview.chromium.org/1155963005/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1155963005/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode282 Source/devtools/front_end/timeline/TimelineEventOverview.js:282: y = 0.5 + Math.round(baseY - visualHeight * Math.min(baseFrameDurationMs ...
4 years, 11 months ago (2015-06-05 08:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155963005/1
4 years, 11 months ago (2015-06-05 11:23:22 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 12:24:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196569

Powered by Google App Engine
This is Rietveld 408576698