Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1155963004: PDF: Cleanup more code now that it is completely out of process. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Cleanup more code now that it is completely out of process. BUG=303491 Committed: https://crrev.com/488102fd0eaea54b3a99804e218fa5163760097d Cr-Commit-Position: refs/heads/master@{#331920}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -51 lines) Patch
M pdf/document_loader.cc View 1 2 3 chunks +20 lines, -11 lines 0 comments Download
M pdf/out_of_process_instance.h View 2 chunks +2 lines, -6 lines 0 comments Download
M pdf/out_of_process_instance.cc View 8 chunks +9 lines, -15 lines 0 comments Download
M pdf/pdf_engine.h View 1 chunk +2 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +1 line, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 5 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
5 years, 6 months ago (2015-05-28 01:26:39 UTC) #2
raymes
https://codereview.chromium.org/1155963004/diff/1/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (left): https://codereview.chromium.org/1155963004/diff/1/pdf/out_of_process_instance.cc#oldcode370 pdf/out_of_process_instance.cc:370: headers = "content-type: application/pdf"; Do we need to preserve ...
5 years, 6 months ago (2015-05-28 02:44:43 UTC) #3
Lei Zhang
https://codereview.chromium.org/1155963004/diff/1/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (left): https://codereview.chromium.org/1155963004/diff/1/pdf/out_of_process_instance.cc#oldcode370 pdf/out_of_process_instance.cc:370: headers = "content-type: application/pdf"; On 2015/05/28 02:44:42, raymes wrote: ...
5 years, 6 months ago (2015-05-28 05:56:33 UTC) #4
raymes
lgtm - I had to think about it a bit but that makes sense. Thanks!
5 years, 6 months ago (2015-05-29 01:21:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155963004/40001
5 years, 6 months ago (2015-05-29 02:09:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-29 03:25:34 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 03:26:30 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/488102fd0eaea54b3a99804e218fa5163760097d
Cr-Commit-Position: refs/heads/master@{#331920}

Powered by Google App Engine
This is Rietveld 408576698