Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1155893003: Add {Map,Set}::FromArray to the API (Closed)

Created:
5 years, 7 months ago by adamk
Modified:
5 years, 6 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add {Map,Set}::FromArray to the API These are similar to the Map/Set constructors when called with an array, except that they are guaranteed to be side-effect free if called with a packed array. This will be useful in implementing structured clone which, as specified in HTML, speaks in terms of the internal [[MapData]] and [[SetData]] slots without going through the exposed iteration ES semantics. BUG=v8:3340 LOG=y Committed: https://crrev.com/cb07b8ef1a5d868a66d847c8d78af58947d21425 Cr-Commit-Position: refs/heads/master@{#28642}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add semicolons #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M include/v8.h View 1 2 2 chunks +17 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/collection.js View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M src/contexts.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-05-26 15:43:01 UTC) #2
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1155893003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1155893003/diff/1/include/v8.h#newcode2986 include/v8.h:2986: * Guaranteed to be side-effect free if the ...
5 years, 6 months ago (2015-05-26 16:37:40 UTC) #4
adamk
https://codereview.chromium.org/1155893003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1155893003/diff/1/include/v8.h#newcode2986 include/v8.h:2986: * Guaranteed to be side-effect free if the array ...
5 years, 6 months ago (2015-05-26 17:27:45 UTC) #5
adamk
5 years, 6 months ago (2015-05-26 17:29:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155893003/40001
5 years, 6 months ago (2015-05-26 18:18:10 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-26 18:50:21 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 18:50:34 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb07b8ef1a5d868a66d847c8d78af58947d21425
Cr-Commit-Position: refs/heads/master@{#28642}

Powered by Google App Engine
This is Rietveld 408576698