IndexedDB: Add draft/proposal links for some experimental APIs in IDLs

IndexedDB: Add draft/proposal links for some experimental APIs in IDLs

For IDL files with experimental API additions,
ensure the file links to the draft spec[1] or
add a link to the tracking issue for the proposal.

Also, remove a stray ? marker on IDObjectStore's 
read-only name attribute, which is not actually nullable.

[1] https://w3c.github.io/IndexedDB/
R=philipj@opera.com,cmumford@chromium.org
BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196339

[jsbell, 2015-06-01 21:21:59]

cmumford@, philipj@ - please take a look?

[cmumford, 2015-06-01 21:29:58]

lgtm.

Nit: not sure what the TODO's are specifying to be done. One is missing a TODO.

[philipj_slow, 2015-06-01 21:41:07]

It's up to the owners of modules/indexeddb (you!) to decide, but in the IDL spec
sync work I've been doing I've changed /TR/ to the most recent draft of any spec
I could find, since that's normally the version you try to implement. If you
convert all of the links to https://w3c.github.io/IndexedDB/ only the bits that
aren't in any spec needs TODOs.

[jsbell, 2015-06-01 21:43:18]

On 2015/06/01 21:29:58, cmumford wrote:
> Nit: not sure what the TODO's are specifying to be done. One is missing a
TODO.

Whoops!

On 2015/06/01 21:41:07, philipj wrote:
> It's up to the owners of modules/indexeddb (you!) to decide, but in the IDL
spec
> sync work I've been doing I've changed /TR/ to the most recent draft of any
spec
> I could find, since that's normally the version you try to implement. If you
> convert all of the links to https://w3c.github.io/IndexedDB/ only the bits
that
> aren't in any spec needs TODOs.

I feel somewhat guilty about that since I'm the one editing the spec draft. :)

[jsbell, 2015-06-01 21:58:45]

CL updated - how's this look?

[cmumford, 2015-06-01 22:04:19]

On 2015/06/01 21:58:45, jsbell wrote:
> CL updated - how's this look?

This leaves behind a bunch of files (IDBCursorWithValue.idl, IDBFactory.idl,
...) with published links. Do you want a mixture, or move them all to the draft
spec?

[jsbell, 2015-06-01 22:05:06]

On 2015/06/01 22:04:19, cmumford wrote:
> On 2015/06/01 21:58:45, jsbell wrote:
> > CL updated - how's this look?
> 
> This leaves behind a bunch of files (IDBCursorWithValue.idl, IDBFactory.idl,
> ...) with published links. Do you want a mixture, or move them all to the
draft
> spec?

I can update them all, unless anyone objects. (Was trying to scope the patch...)

[blink-reviews, 2015-06-01 22:05:56]

Not asking for it, just wanted to point it out. I'm still good with the CL.

On Mon, Jun 1, 2015 at 3:05 PM <jsbell@chromium.org> wrote:

> On 2015/06/01 22:04:19, cmumford wrote:
> > On 2015/06/01 21:58:45, jsbell wrote:
> > > CL updated - how's this look?
>
> > This leaves behind a bunch of files (IDBCursorWithValue.idl,
> > IDBFactory.idl,
> > ...) with published links. Do you want a mixture, or move them all to the
> draft
> > spec?
>
> I can update them all, unless anyone objects. (Was trying to scope the
> patch...)
>
> https://codereview.chromium.org/1155883005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[philipj_slow, 2015-06-01 22:12:27]

This LGTM with nit about nullability

https://codereview.chromium.org/1155883005/diff/20001/Source/modules/indexedd...
File Source/modules/indexeddb/IDBObjectStore.idl (right):

https://codereview.chromium.org/1155883005/diff/20001/Source/modules/indexedd...
Source/modules/indexeddb/IDBObjectStore.idl:32: readonly attribute DOMString
name;
Note that this does change the generated code, from v8SetReturnValueStringOrNull
to v8SetReturnValueString. (For objects like Node, however, nullability makes no
difference for readonly and return types.)

Is it possible for IDBObjectStore::name() to return a null string? If not, maybe
note that in the description so that it's clear that no observable change in
behavior is intended.

[jsbell, 2015-06-01 23:37:35]

https://codereview.chromium.org/1155883005/diff/20001/Source/modules/indexedd...
File Source/modules/indexeddb/IDBObjectStore.idl (right):

https://codereview.chromium.org/1155883005/diff/20001/Source/modules/indexedd...
Source/modules/indexeddb/IDBObjectStore.idl:32: readonly attribute DOMString
name;
On 2015/06/01 22:12:27, philipj wrote:
> Note that this does change the generated code, from
v8SetReturnValueStringOrNull
> to v8SetReturnValueString.

Ah, yes, sorry - I meant to comment on that.

I noticed the ? when looking for other IDL diversions. It looks like it dates
back as far as https://bugs.webkit.org/show_bug.cgi?id=58365 where I think it
was added as a misunderstanding.

Name can never be null; calling createObjectStore(null).name will yield the
literal string "null" as the argument goes through the IDL conversion logic.

[jsbell, 2015-06-01 23:37:40]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2015-06-01 23:37:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/1155883005/#ps20001
(title: "remove comments for draft spec'd features, update spec links")

[commit-bot: I haz the power, 2015-06-01 23:38:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155883005/20001

[commit-bot: I haz the power, 2015-06-02 01:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 01:09:14]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64694)

[jsbell, 2015-06-02 18:03:22]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2015-06-02 18:03:22]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com,
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/1155883005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-06-02 18:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155883005/40001

[commit-bot: I haz the power, 2015-06-02 19:56:18]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196339