Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155863003: chrome/settings: Shorten string names for accessibility. (Closed)

Created:
5 years, 6 months ago by James Hawkins
Modified:
5 years, 6 months ago
Reviewers:
jlklein, Jeremy Klein
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/settings: Shorten string names for accessibility. R=jlklein@chromium.org, jlklein BUG= Committed: https://crrev.com/71107f7658fb959dc40493303ac8f9b6e63ab5e2 Cr-Commit-Position: refs/heads/master@{#333063}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -90 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +18 lines, -18 lines 2 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +23 lines, -36 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +19 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
James Hawkins
5 years, 6 months ago (2015-06-05 15:51:57 UTC) #1
Jeremy Klein
lgtm https://codereview.chromium.org/1155863003/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1155863003/diff/1/chrome/app/settings_strings.grdp#newcode45 chrome/app/settings_strings.grdp:45: extremeley short While you're here: s/extremeley/extremely. That's been ...
5 years, 6 months ago (2015-06-05 16:22:00 UTC) #3
James Hawkins
https://codereview.chromium.org/1155863003/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1155863003/diff/1/chrome/app/settings_strings.grdp#newcode45 chrome/app/settings_strings.grdp:45: extremeley short On 2015/06/05 16:22:00, Jeremy Klein wrote: > ...
5 years, 6 months ago (2015-06-05 16:22:36 UTC) #4
James Hawkins
Committed patchset #1 (id:1) manually as 71107f7658fb959dc40493303ac8f9b6e63ab5e2 (presubmit successful).
5 years, 6 months ago (2015-06-05 16:27:35 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:27:42 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/71107f7658fb959dc40493303ac8f9b6e63ab5e2
Cr-Commit-Position: refs/heads/master@{#333063}

Powered by Google App Engine
This is Rietveld 408576698