Issue 115586: Unified the ways Font and Canvas get the pixel size of strings, using pango

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115586: Unified the ways Font and Canvas get the pixel size of strings, using pango (Closed)

Created:
11 years, 7 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, sky, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unified the ways Font and Canvas get the pixel size of strings, using pango Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16535

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -15 lines)			Patch
	M	app/gfx/canvas_linux.cc	View	1	1 chunk	+33 lines, -1 line	0 comments	Download
	M	app/gfx/font_skia.cc	View		2 chunks	+5 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

As we were saying over lunch, I'm a little skeptical that the string size will ...

11 years, 7 months ago (2009-05-20 20:37:33 UTC) #2

Dean McNamee

11 years, 4 months ago (2009-08-13 00:28:30 UTC) #3

This is kind of an abstraction violation (font should not know anything about
canvas).  Just sayin.

On 2009/05/20 20:37:33, Evan Martin wrote:
> As we were saying over lunch, I'm a little skeptical that the string size will
> come out the same because Skia fonts aren't drawn with Pango.  But in practice
> this is likely good enough to get you going.
> 
> WebKit drawing of text:
>   WebKit (built-in BIDI) -> skia -> harfbuzz (shaping) -> freetype
> 
> Pango drawing of text:
>   Pango (built in BIDI, kerning) -> harfbuzz -> freetype
> 
> Canvas drawing of text:
>   Skia -> ...   (note absence of BIDI and kerning)

Expand Messages | Collapse Messages