Making TimeToConnect metric more robust

Making TimeToConnect metric more robust

We have seen large percentage of WebRTC calls where the TimeToConnect goes larger than 180 sec. By looking at the code, one reason that this happens is that if kIceConnectionChecking is not fired, the current code will report a huge number.

I haven't yet found a place where Checking state will be skipped but this is just to make the code more robust.

BUG=webrtc:4278
Committed: https://crrev.com/2ae183cb097d5c13cbaf98eb81b51dcbdc50fe48
Cr-Commit-Position: refs/heads/master@{#333334}

[guoweis_left_chromium, 2015-06-01 22:14:41]

guoweis@chromium.org changed reviewers:
+ pthatcher@chromium.org

[guoweis_left_chromium, 2015-06-01 22:14:42]

PTAL.

[guoweis_left_chromium, 2015-06-01 22:36:35]

guoweis@chromium.org changed reviewers:
+ perkj@chromium.org

[guoweis_left_chromium, 2015-06-01 22:36:36]

perkj@chromium.org: PTAL.

[pthatcher2, 2015-06-01 23:02:15]

lgtm

https://codereview.chromium.org/1155833006/diff/1/content/renderer/media/rtc_...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/1155833006/diff/1/content/renderer/media/rtc_...
content/renderer/media/rtc_peer_connection_handler.cc:1311: base::TimeDelta());
Can you put a comment explaining why it's correct that the value will be zero?

[guoweis_left_chromium, 2015-06-04 21:16:45]

guoweis@chromium.org changed reviewers:
- perkj@chromium.org

[guoweis_left_chromium, 2015-06-04 21:17:51]

guoweis@chromium.org changed reviewers:
+ tommi@chromium.org

[guoweis_left_chromium, 2015-06-04 21:17:52]

Tommi, PTAL.

[tommi (sloooow) - chröme, 2015-06-08 18:14:41]

On 2015/06/04 at 21:17:52, guoweis wrote:
> Tommi, PTAL.

Lgtm with Peter's comment addressed

[guoweis_left_chromium, 2015-06-08 19:55:38]

landing this now after addressing Peter's comment.

https://codereview.chromium.org/1155833006/diff/1/content/renderer/media/rtc_...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/1155833006/diff/1/content/renderer/media/rtc_...
content/renderer/media/rtc_peer_connection_handler.cc:1311: base::TimeDelta());
On 2015/06/01 23:02:15, pthatcher2 wrote:
> Can you put a comment explaining why it's correct that the value will be zero?

Done.

[guoweis_left_chromium, 2015-06-08 19:55:42]

The CQ bit was checked by guoweis@chromium.org

[guoweis_left_chromium, 2015-06-08 19:55:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@chromium.org, tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1155833006/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-06-08 19:56:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155833006/20001

[commit-bot: I haz the power, 2015-06-08 20:51:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-08 20:54:00]

Patchset 2 (id:??) landed as
https://crrev.com/2ae183cb097d5c13cbaf98eb81b51dcbdc50fe48
Cr-Commit-Position: refs/heads/master@{#333334}