Tests that Permissions API and requestMidiAccess() are consistent.

Tests that Permissions API and requestMidiAccess() are consistent.

BUG=474545
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196329

[mlamouri (slow - plz ping), 2015-05-22 10:46:19]

mlamouri@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2015-05-25 03:28:11]

Does this make sense?
Layout test implements a specific permission manager for testing. It seems that
my original simple mock for MIDI was replaced with a LayoutTestPermissionManager
to handle all permissions, so my concern could be wrong. But, I'm afraid that it
does not reach content settings layers, and code path is completely different
between tests and the production.

[mlamouri (slow - plz ping), 2015-05-29 13:42:40]

On 2015/05/25 at 03:28:11, toyoshim wrote:
> Does this make sense?
> Layout test implements a specific permission manager for testing. It seems
that my original simple mock for MIDI was replaced with a
LayoutTestPermissionManager to handle all permissions, so my concern could be
wrong. But, I'm afraid that it does not reach content settings layers, and code
path is completely different between tests and the production.

That's correct. We could not land that test but I think it does underline a
requirement of the API which isn't bad to have as a test.

WDYT?

[Takashi Toyoshima, 2015-05-30 22:02:32]

I think it's ok to have this test, but we may want to add some comments in the
test so that someone who works on this feature won't be confused.

[mlamouri (slow - plz ping), 2015-06-01 12:48:37]

Comments added. PTAL.

[Takashi Toyoshima, 2015-06-02 02:40:22]

lgtm with one comment.

[Takashi Toyoshima, 2015-06-02 02:40:38]

Oops, comment is here.

https://codereview.chromium.org/1155823002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/test-midi-sysex-insecure-origin.html
(right):

https://codereview.chromium.org/1155823002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/test-midi-sysex-insecure-origin.html:14: //
the Permissions API calls are using a mock implementation of the backend.
Can you do s/the Permission API/the Permission API and requestMIDIAccess of the
Web MIDI API/?

[mlamouri (slow - plz ping), 2015-06-02 08:22:43]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-06-02 08:22:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/1155823002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2015-06-02 08:23:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155823002/40001

[commit-bot: I haz the power, 2015-06-02 10:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 10:11:16]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[mlamouri (slow - plz ping), 2015-06-02 10:11:58]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-06-02 10:12:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155823002/40001

[commit-bot: I haz the power, 2015-06-02 12:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 12:01:11]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[mlamouri (slow - plz ping), 2015-06-02 12:28:55]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-06-02 12:29:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155823002/40001

[commit-bot: I haz the power, 2015-06-02 14:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 14:14:07]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[mlamouri (slow - plz ping), 2015-06-02 14:52:13]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-06-02 14:52:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155823002/40001

[commit-bot: I haz the power, 2015-06-02 16:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:34:25]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[mlamouri (slow - plz ping), 2015-06-02 16:38:29]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:38:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155823002/40001

[commit-bot: I haz the power, 2015-06-02 16:43:10]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196329