runtime/bin/main.cc - Issue 11558012: Use FormatMessageW for Windows error messages to handle internationalized messages correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/main.cc

Issue 11558012: Use FormatMessageW for Windows error messages to handle internationalized messages correctly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/main.cc

diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc

index 8700364b990d014a83c82fd93dd6e8f0469bbe09..63d00dc5c9ff1790a536c34237342d2c4ee08ea3 100644

--- a/runtime/bin/main.cc

+++ b/runtime/bin/main.cc

@@ -257,7 +257,7 @@ static bool Utf8ConvertArgv(int argc, char** argv) {

bool result = false;

for (int i = 0; i < argc; i++) {

char* arg = argv[i];

- argv[i] = StringUtils::SystemStringToUtf8(arg);

+ argv[i] = StringUtils::ConsoleStringToUtf8(arg);

if (i == 0) {

result = argv[i] != arg;

} else {

« no previous file with comments | « runtime/bin/file_win.cc ('k') | runtime/bin/platform.h » ('j') | no next file with comments »