Use FormatMessageW for Windows error messages to handle internationalized messages correctly.

runtime/bin/process.cc

Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index e513939d4405a27075ee57726748793e28d78782..740e4a4e5011a6ba8b7582083e18e88cae38b5d3 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -122,8 +122,7 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
   Dart_Handle err_handle = Dart_GetNativeArgument(args, 7);
   Dart_Handle exit_handle = Dart_GetNativeArgument(args, 8);
   intptr_t pid = -1;
-  static const int kMaxChildOsErrorMessageLength = 256;
-  char os_error_message[kMaxChildOsErrorMessageLength];
+  char* os_error_message = NULL;
 
   int error_code = Process::Start(path,
                                   string_args,
@@ -136,7 +135,7 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
                                   &err,
                                   &pid,
                                   &exit_event,
-      os_error_message, kMaxChildOsErrorMessageLength);
+                                  &os_error_message);
   if (error_code == 0) {
     Socket::SetSocketIdNativeField(in_handle, in);
     Socket::SetSocketIdNativeField(out_handle, out);
@@ -151,6 +150,7 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
   }
   delete[] string_args;
   delete[] string_environment;
+  free(os_error_message);

[Søren Gjesse, 2012/12/12 14:00:38]

Consider allocating os_error_message using new making these all delete[] calls.
As far as I can see all these strings are duplicated/allocated in our code.

In V8 we had the NewArray/DeleteArray to encapsulate this.

[Mads Ager (google), 2012/12/12 14:38:00]

For now I'm just consistently using free for all of these. That fits best with
the shared code where we get malloced stuff back from posix systems. I'll be
happy to do a sweep over the code to see if we can switch to using
new[]/delete[] for these as well. It does look weird with the mix here.

   Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
   Dart_ExitScope();
 }
@@ -194,7 +194,7 @@ void FUNCTION_NAME(SystemEncodingToString)(Dart_NativeArguments args) {
     Dart_PropagateError(result);
   }
   char* str =
-      StringUtils::SystemStringToUtf8(reinterpret_cast<char*>(buffer));
+      StringUtils::ConsoleStringToUtf8(reinterpret_cast<char*>(buffer));
   Dart_SetReturnValue(args, DartUtils::NewString(str));
   if (str != reinterpret_cast<char*>(buffer)) free(str);
   Dart_ExitScope();
@@ -205,7 +205,7 @@ void FUNCTION_NAME(StringToSystemEncoding)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle str = Dart_GetNativeArgument(args, 0);
   const char* utf8 = DartUtils::GetStringValue(str);
-  const char* system_string = StringUtils::Utf8ToSystemString(utf8);
+  const char* system_string = StringUtils::Utf8ToConsoleString(utf8);
   int external_length = strlen(system_string);
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(external_length, &buffer);