Use FormatMessageW for Windows error messages to handle internationalized messages correctly.

runtime/bin/process.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/process.h"
 #include "bin/socket.h"
 
 #include "include/dart_api.h"
@@ skipping 104 matching lines @@
       Dart_SetReturnValue(args, Dart_NewBoolean(false));
       Dart_ExitScope();
       return;
     }
   }
   Dart_Handle in_handle = Dart_GetNativeArgument(args, 5);
   Dart_Handle out_handle = Dart_GetNativeArgument(args, 6);
   Dart_Handle err_handle = Dart_GetNativeArgument(args, 7);
   Dart_Handle exit_handle = Dart_GetNativeArgument(args, 8);
   intptr_t pid = -1;
-  static const int kMaxChildOsErrorMessageLength = 256;
-  char os_error_message[kMaxChildOsErrorMessageLength];
+  char* os_error_message = NULL;
 
   int error_code = Process::Start(path,
                                   string_args,
                                   args_length,
                                   working_directory,
                                   string_environment,
                                   environment_length,
                                   &in,
                                   &out,
                                   &err,
                                   &pid,
                                   &exit_event,
-      os_error_message, kMaxChildOsErrorMessageLength);
+                                  &os_error_message);
   if (error_code == 0) {
     Socket::SetSocketIdNativeField(in_handle, in);
     Socket::SetSocketIdNativeField(out_handle, out);
     Socket::SetSocketIdNativeField(err_handle, err);
     Socket::SetSocketIdNativeField(exit_handle, exit_event);
     Process::SetProcessIdNativeField(process, pid);
   } else {
     DartUtils::SetIntegerField(
         status_handle, "_errorCode", error_code);
     DartUtils::SetStringField(
         status_handle, "_errorMessage", os_error_message);
   }
   delete[] string_args;
   delete[] string_environment;
+  free(os_error_message);
   Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Process_Kill)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle process = Dart_GetNativeArgument(args, 1);
   intptr_t pid = -1;
   Process::GetProcessIdNativeField(process, &pid);
@@ skipping 23 matching lines @@
   Dart_Handle result = Dart_ListLength(bytes, &bytes_length);
   if (Dart_IsError(result)) Dart_PropagateError(result);
   uint8_t* buffer = new uint8_t[bytes_length + 1];
   result = Dart_ListGetAsBytes(bytes, 0, buffer, bytes_length);
   buffer[bytes_length] = '\0';
   if (Dart_IsError(result)) {
     delete[] buffer;
     Dart_PropagateError(result);
   }
   char* str =
-      StringUtils::SystemStringToUtf8(reinterpret_cast<char*>(buffer));
+      StringUtils::ConsoleStringToUtf8(reinterpret_cast<char*>(buffer));
   Dart_SetReturnValue(args, DartUtils::NewString(str));
   if (str != reinterpret_cast<char*>(buffer)) free(str);
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(StringToSystemEncoding)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle str = Dart_GetNativeArgument(args, 0);
   const char* utf8 = DartUtils::GetStringValue(str);
-  const char* system_string = StringUtils::Utf8ToSystemString(utf8);
+  const char* system_string = StringUtils::Utf8ToConsoleString(utf8);
   int external_length = strlen(system_string);
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(external_length, &buffer);
   memmove(buffer, system_string, external_length);
   if (utf8 != system_string) free(const_cast<char*>(system_string));
   Dart_SetReturnValue(args, external_array);
   Dart_ExitScope();
 }