Devtools Animations: Add cubic bezier easing editor for animations

Source/devtools/front_end/elements/AnimationTimeline.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.AnimationTimeline = function()
@@ skipping 11 matching lines @@
     this.contentElement.appendChild(this._createHeader());
     this._animationsContainer = this.contentElement.createChild("div", "animation-timeline-rows");
     this._duration = this._defaultDuration();
     this._scrubberRadius = 25;
     this._timelineControlsWidth = 200;
     /** @type {!Map.<!DOMAgent.BackendNodeId, !WebInspector.AnimationTimeline.NodeUI>} */
     this._nodesMap = new Map();
     this._symbol = Symbol("animationTimeline");
     /** @type {!Map.<string, !WebInspector.AnimationModel.AnimationPlayer>} */
     this._animationsMap = new Map();
+    this._timelineBezierEditor = new WebInspector.AnimationTimeline.BezierEditor();
+
     WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
     WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.NodeRemoved, this._nodeRemoved, this);
 
     WebInspector.targetManager.observeTargets(this);
 }
 
 WebInspector.AnimationTimeline.GlobalPlaybackRates = [0.1, 0.25, 0.5, 1.0];
 
 WebInspector.AnimationTimeline.prototype = {
     wasShown: function()
@@ skipping 522 matching lines @@
     _scrubberDragEnd: function(event)
     {
         if (this._scrubberPlayer.currentTime < this.duration() - this._scrubberRadius / this.pixelMsRatio())
             this._scrubberPlayer.play();
         this._timelineScrubberHead.window().requestAnimationFrame(this._updateScrubber.bind(this));
         var target = WebInspector.targetManager.mainTarget();
         if (target)
             target.animationModel.setPlaybackRate(this._playbackRate());
     },
 
+    /**
+     * @return {!WebInspector.AnimationTimeline.BezierEditor}
+     */
+    bezierEditor: function()
+    {
+        return this._timelineBezierEditor;
+    },
+
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @constructor
  * @param {!WebInspector.AnimationModel.AnimationNode} animationNode
  */
 WebInspector.AnimationTimeline.NodeUI = function(animationNode) {
     /**
      * @param {?WebInspector.DOMNode} node
@@ skipping 100 matching lines @@
     this._animation = animation;
     this._timeline = timeline;
     this._parentElement = parentElement;
 
     if (this._animation.source().keyframesRule())
         this._keyframes =  this._animation.source().keyframesRule().keyframes();
 
     this._nameElement = parentElement.createChild("div", "animation-name");
     this._nameElement.textContent = this._animation.name();
 
+    this._bezierIconElement = WebInspector.BezierPopoverIcon.createIcon(parentElement);
+    this._bezierIconElement.style.backgroundColor = this._color();
+    var editor = this._timeline.bezierEditor();
+    this._bezierIconElement.addEventListener("mousedown", editor.toggle.bind(editor, this, this._bezierIconElement));
+
     this._svg = parentElement.createSVGChild("svg", "animation-ui");
     this._svg.setAttribute("height", WebInspector.AnimationUI.Options.AnimationSVGHeight);
     this._svg.style.marginLeft = "-" + WebInspector.AnimationUI.Options.AnimationMargin + "px";
     this._svg.addEventListener("mousedown", this._mouseDown.bind(this, WebInspector.AnimationUI.MouseEvents.AnimationDrag, null));
     this._activeIntervalGroup = this._svg.createSVGChild("g");
+    this._activeIntervalGroup.addEventListener("mouseover", this._toggleBezierIcon.bind(this, true));
+    this._activeIntervalGroup.addEventListener("mouseout", this._toggleBezierIcon.bind(this, false));
 
     /** @type {!Array.<{group: ?Element, animationLine: ?Element, keyframePoints: !Object.<number, !Element>, keyframeRender: !Object.<number, !Element>}>} */
     this._cachedElements = [];
 
     this._movementInMs = 0;
     this.redraw();
 }
 
 /**
  * @enum {string}
@@ skipping 152 matching lines @@
         var durationWithDelay = this._delay() + this._duration() * this._animation.source().iterations() + this._animation.source().endDelay();
         var leftMargin = ((this._animation.startTime() - this._timeline.startTime()) * this._timeline.pixelMsRatio());
         var maxWidth = this._timeline.width() - WebInspector.AnimationUI.Options.AnimationMargin - leftMargin;
         var svgWidth = Math.min(maxWidth, durationWithDelay * this._timeline.pixelMsRatio());
 
         this._svg.classList.toggle("animation-ui-canceled", this._animation.playState() === "idle");
         this._svg.setAttribute("width", (svgWidth + 2 * WebInspector.AnimationUI.Options.AnimationMargin).toFixed(2));
         this._svg.style.transform = "translateX(" + leftMargin.toFixed(2)  + "px)";
         this._activeIntervalGroup.style.transform = "translateX(" + (this._delay() * this._timeline.pixelMsRatio()).toFixed(2) + "px)";
 
-        this._nameElement.style.transform = "translateX(" + (leftMargin + this._delay() * this._timeline.pixelMsRatio() + WebInspector.AnimationUI.Options.AnimationMargin).toFixed(2) + "px)";
+        var leftPosition = (leftMargin + this._delay() * this._timeline.pixelMsRatio() + WebInspector.AnimationUI.Options.AnimationMargin).toFixed(2);
+        this._nameElement.style.transform = "translateX(" + leftPosition + "px)";
+        this._bezierIconElement.style.marginLeft = leftPosition + "px";
         this._nameElement.style.width = (this._duration() * this._timeline.pixelMsRatio().toFixed(2)) + "px";
         this._drawDelayLine(this._svg);
 
         if (this._animation.type() === "CSSTransition") {
             this._renderTransition();
             return;
         }
 
         this._renderIteration(this._activeIntervalGroup, 0);
         if (!this._tailGroup)
             this._tailGroup = this._activeIntervalGroup.createSVGChild("g", "animation-tail-iterations");
         var iterationWidth = this._duration() * this._timeline.pixelMsRatio();
         for (var iteration = 1; iteration < this._animation.source().iterations() && iterationWidth * (iteration - 1) < this._timeline.width(); iteration++)
             this._renderIteration(this._tailGroup, iteration);
         while (iteration < this._cachedElements.length)
             this._cachedElements.pop().group.remove();
     },
 
-
     _renderTransition: function()
     {
         if (!this._cachedElements[0])
             this._cachedElements[0] = { animationLine: null, keyframePoints: {}, keyframeRender: {}, group: null };
         this._drawAnimationLine(0, this._activeIntervalGroup);
         this._renderKeyframe(0, 0, this._activeIntervalGroup, WebInspector.AnimationUI.Options.AnimationMargin, this._duration() * this._timeline.pixelMsRatio(), this._animation.source().easing());
         this._drawPoint(0, this._activeIntervalGroup, WebInspector.AnimationUI.Options.AnimationMargin, 0, true);
         this._drawPoint(0, this._activeIntervalGroup, this._duration() * this._timeline.pixelMsRatio() + WebInspector.AnimationUI.Options.AnimationMargin, -1, true);
     },
 
@@ skipping 122 matching lines @@
         this._parentElement.ownerDocument.removeEventListener("mousemove", this._mouseMoveHandler);
         this._parentElement.ownerDocument.removeEventListener("mouseup", this._mouseUpHandler);
         delete this._mouseMoveHandler;
         delete this._mouseUpHandler;
         delete this._mouseEventType;
         delete this._downMouseX;
         delete this._keyframeMoved;
     },
 
     /**
+     * @param {boolean} show
+     */
+    _toggleBezierIcon: function(show)
+    {
+        var bezier = WebInspector.Geometry.CubicBezier.parse(this._animation.source().easing());
+        if (show && (this._animation.playState() === "idle" || !bezier))
+            return;
+        this._bezierIconElement.classList.toggle("shown", show);
+    },
+
+    /**
+     * @param {string} value
+     */
+    _setEasing: function(value)
+    {
+        if (!this._node || this._animation.source().easing() == value)

[dgozman, 2015/05/26 12:02:23]

===

[samli, 2015/05/27 05:21:59]

Done.

+            return;
+
+        this._animation.source().setEasing(value);
+        this.redraw();
+
+        var animationType = this._animation.type();
+        if (animationType !== "CSSAnimation") {
+            var target = WebInspector.targetManager.mainTarget();
+            if (target)
+                target.animationAgent().setEasing(this._animation.id(), value);

[dgozman, 2015/05/26 12:02:23]

UI should not call animationAgent() and operate with target. Instead, we should
have |this._animationModel| and call methods on it.

[samli, 2015/05/27 05:21:59]

Ack.

+        }
+
+        if (animationType !== "WebAnimation")
+            this._setNodeStyle(animationType === "CSSTransition" ? "transition-timing-function" : "animation-timing-function", value);
+    },
+
+    /**
      * @param {number} value
      */
     _setDelay: function(value)
     {
         if (!this._node || this._animation.source().delay() == this._delay())
             return;
 
         this._animation.source().setDelay(this._delay());
         var propertyName;
         if (this._animation.type() == "CSSTransition")
@@ skipping 27 matching lines @@
     /**
      * @param {string} name
      * @param {string} value
      */
     _setNodeStyle: function(name, value)
     {
         var style = this._node.getAttribute("style") || "";
         if (style)
             style = style.replace(new RegExp("\\s*(-webkit-)?" + name + ":[^;]*;?\\s*", "g"), "");
         var valueString = name + ": " + value;
-        this._node.setAttributeValue("style", style + " " + valueString + "; -webkit-" + valueString + ";");
+        this._node.setAttributeValue("style", style + " " + valueString + ";");
     },
 
     /**
      * @return {string}
      */
     _color: function()
     {
         /**
          * @param {string} string
          * @return {number}
@@ skipping 28 matching lines @@
     "Light Blue": WebInspector.Color.parse("#03A9F4"),
     "Deep Orange": WebInspector.Color.parse("#FF5722"),
     "Blue": WebInspector.Color.parse("#5677FC"),
     "Lime": WebInspector.Color.parse("#CDDC39"),
     "Blue Grey": WebInspector.Color.parse("#607D8B"),
     "Pink": WebInspector.Color.parse("#E91E63"),
     "Green": WebInspector.Color.parse("#0F9D58"),
     "Brown": WebInspector.Color.parse("#795548"),
     "Cyan": WebInspector.Color.parse("#00BCD4")
 }
+
+/**
+ * @constructor
+ */
+WebInspector.AnimationTimeline.BezierEditor = function()
+{
+    this._popover = new WebInspector.Popover();
+    this._popover.setCanShrink(false);
+    this._popover.setNoMargins(true);
+    this._bezierEditor = new WebInspector.BezierEditor();
+    this._boundOnKeyDown = this._onKeyDown.bind(this);
+    this._boundOnFocusOut = this._onFocusOut.bind(this);
+}
+
+WebInspector.AnimationTimeline.BezierEditor.prototype = {

[dgozman, 2015/05/26 12:02:23]

That's quite a lot of code duplication. Perhaps, we should rename
StylesPopoverHelper into EditorPopoverHelper, place it in ui module and reuse
here. Sorry for not spotting this earlier.

[samli, 2015/05/27 05:21:59]

Reluctantly done.

+    /**
+     * @param {!WebInspector.AnimationUI} animationUI
+     * @param {!Element} anchorElement
+     * @param {!Event} event
+     */
+    toggle: function(animationUI, anchorElement, event)
+    {
+        var shouldShow = !this._popover.isShowing() || this._animationUI !== animationUI;
+        if (this._popover.isShowing())
+            this._hide(true);
+        if (shouldShow)
+            this._show(animationUI, anchorElement, event);
+        event.stopPropagation();
+        event.preventDefault();
+    },
+
+    /**
+     * @param {!WebInspector.AnimationUI} animationUI
+     * @param {!Element} anchorElement
+     * @param {!Event} event
+     */
+    _show: function(animationUI, anchorElement, event)
+    {
+        this._animationUI = animationUI;
+        this._anchorElement = anchorElement;
+        this._previousFocusElement = WebInspector.currentFocusElement();
+
+        this._originalEasing = this._animationUI.animation().source().easing();
+        var bezier = WebInspector.Geometry.CubicBezier.parse(this._originalEasing);
+        this._bezierEditor.setBezier(bezier);
+        this._bezierEditor.addEventListener(WebInspector.BezierEditor.Events.BezierChanged, this._bezierChanged, this);
+        this._popover.showView(this._bezierEditor, this._anchorElement);
+        this._bezierEditor.contentElement.addEventListener("keydown", this._boundOnKeyDown);
+        this._bezierEditor.contentElement.addEventListener("focusout", this._boundOnFocusOut);
+        this._anchorElement.classList.add("bezier-editor-open");
+        WebInspector.setCurrentFocusElement(this._bezierEditor.contentElement);
+    },
+
+    /**
+     * @param {boolean=} commitEdit
+     */
+    _hide: function(commitEdit)
+    {
+        if (!this._popover.isShowing())
+            return;
+        this._anchorElement.classList.remove("bezier-editor-open");
+        this._bezierEditor.removeEventListener(WebInspector.BezierEditor.Events.BezierChanged, this._bezierChanged, this);
+        if (!commitEdit)
+            this._animationUI._setEasing(this._originalEasing);
+        this._popover.hide();
+        this._bezierEditor.detach();
+        this._bezierEditor.contentElement.removeEventListener("keydown", this._boundOnKeyDown);
+        this._bezierEditor.contentElement.removeEventListener("focusout", this._boundOnFocusOut);
+        WebInspector.setCurrentFocusElement(this._previousFocusElement);
+    },
+
+    /**
+     * @param {!Event} event
+     */
+    _onFocusOut: function(event)
+    {
+        this._hide(true);
+    },
+
+    /**
+     * @param {!Event} event
+     */
+    _onKeyDown: function(event)
+    {
+        if (event.keyIdentifier === "Enter") {
+            this._hide(true);
+            event.consume(true);
+            return;
+        }
+        if (event.keyIdentifier === "U+001B") { // Escape key
+            this._hide(false);
+            event.consume(true);
+        }
+    },
+
+    /**
+     * @param {!WebInspector.Event} event
+     */
+    _bezierChanged: function(event)
+    {
+        this._animationUI._setEasing(/** @type {string} */ (event.data));
+    }
+}