Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 115575: Move ExtraData from WebRequest to WebDataSource.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_webview_delegate.cc
===================================================================
--- webkit/tools/test_shell/test_webview_delegate.cc (revision 16382)
+++ webkit/tools/test_shell/test_webview_delegate.cc (working copy)
@@ -243,6 +243,11 @@
resource_identifier_map_.erase(identifier);
}
+void TestWebViewDelegate::DidCreateDataSource(WebFrame* frame,
+ WebDataSource* ds) {
+ ds->SetExtraData(pending_extra_data_.release());
+}
+
void TestWebViewDelegate::DidStartProvisionalLoadForFrame(
WebView* webview,
WebFrame* frame,
@@ -296,13 +301,13 @@
if (error.GetErrorCode() == net::ERR_ABORTED)
return;
- const WebRequest& failed_request =
- frame->GetProvisionalDataSource()->GetRequest();
- TestShellExtraRequestData* extra_data =
- static_cast<TestShellExtraRequestData*>(failed_request.GetExtraData());
+ const WebDataSource* failed_ds = frame->GetProvisionalDataSource();
+
+ TestShellExtraData* extra_data =
+ static_cast<TestShellExtraData*>(failed_ds->GetExtraData());
bool replace = extra_data && extra_data->pending_page_id != -1;
- scoped_ptr<WebRequest> request(failed_request.Clone());
+ scoped_ptr<WebRequest> request(failed_ds->GetRequest().Clone());
std::string error_text =
StringPrintf("Error %d when loading url %s", error.GetErrorCode(),
@@ -386,6 +391,8 @@
void TestWebViewDelegate::DidChangeLocationWithinPageForFrame(
WebView* webview, WebFrame* frame, bool is_new_navigation) {
+ frame->GetDataSource()->SetExtraData(pending_extra_data_.release());
+
if (shell_->ShouldDumpFrameLoadCallbacks()) {
printf("%S - didChangeLocationWithinPageForFrame\n",
GetFrameDescription(frame).c_str());
@@ -809,13 +816,9 @@
void TestWebViewDelegate::UpdateForCommittedLoad(WebFrame* frame,
bool is_new_navigation) {
- WebView* webview = shell_->webView();
-
// Code duplicated from RenderView::DidCommitLoadForFrame.
- const WebRequest& request =
- webview->GetMainFrame()->GetDataSource()->GetRequest();
- TestShellExtraRequestData* extra_data =
- static_cast<TestShellExtraRequestData*>(request.GetExtraData());
+ TestShellExtraData* extra_data = static_cast<TestShellExtraData*>(
+ frame->GetDataSource()->GetExtraData());
if (is_new_navigation) {
// New navigation.
« chrome/renderer/render_view.cc ('K') | « webkit/tools/test_shell/test_webview_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698