Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: webkit/glue/webframeloaderclient_impl.cc

Issue 115575: Move ExtraData from WebRequest to WebDataSource.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/webframeloaderclient_impl.cc
===================================================================
--- webkit/glue/webframeloaderclient_impl.cc (revision 16382)
+++ webkit/glue/webframeloaderclient_impl.cc (working copy)
@@ -687,12 +687,6 @@
// Regardless of how we got here, we are navigating to a URL so we need to
// add it to the redirect chain.
ds->AppendRedirect(url);
-
- // WebKit will re-use requests for in-page navigations, but we want to
- // think of it as a new request that has a page ID in session history.
- // This will set the proper page ID, etc. on the request so that the
- // browser will treat it properly.
- webframe_->CacheCurrentRequestInfo(ds);
}
bool is_new_navigation;
@@ -1347,7 +1341,9 @@
const ResourceRequest& request,
const SubstituteData& data) {
RefPtr<WebDataSourceImpl> ds = WebDataSourceImpl::Create(request, data);
- webframe_->CacheCurrentRequestInfo(ds.get());
+ WebViewDelegate* d = webframe_->GetWebViewImpl()->delegate();
+ if (d)
+ d->DidCreateDataSource(webframe_, ds.get());
return ds.release();
}

Powered by Google App Engine
This is Rietveld 408576698