Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1155743013: Move third_party/freetype DEPS to third_party/freetype-android/src (Closed)

Created:
5 years, 6 months ago by bungeman-chromium
Modified:
5 years, 6 months ago
Reviewers:
Nico, Xianzhu, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move third_party/freetype DEPS to third_party/freetype-android/src This allows the build files to live in the chromium repo but the source to live in the freetype repo, similar to other third_party DEPS. Committed: https://crrev.com/7ffe490b7c43e2f9393caf283d809c1983bbeb3e Cr-Commit-Position: refs/heads/master@{#332616}

Patch Set 1 #

Patch Set 2 : Fix gyp build. #

Total comments: 4

Patch Set 3 : Update license location, security property, and OWNERS. #

Patch Set 4 : Actually update security property. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -58 lines) Patch
M .gitignore View 1 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
D build/secondary/third_party/freetype/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_library.gypi View 1 chunk +1 line, -1 line 0 comments Download
A third_party/freetype-android/BUILD.gn View 1 chunk +50 lines, -0 lines 0 comments Download
A + third_party/freetype-android/OWNERS View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
A third_party/freetype-android/README.chromium View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/freetype-android/freetype.gyp View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155743013/1
5 years, 6 months ago (2015-06-02 22:23:47 UTC) #2
bungeman-chromium
This is an alternative to https://codereview.chromium.org/1159323004/ . I tried just moving the DEPS from third_party/freetype ...
5 years, 6 months ago (2015-06-02 22:28:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/22119) cast_shell_android on ...
5 years, 6 months ago (2015-06-02 22:54:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155743013/20001
5 years, 6 months ago (2015-06-02 23:49:02 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/29215)
5 years, 6 months ago (2015-06-03 02:01:01 UTC) #10
Xianzhu
Thanks for working on this. lgtm https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/OWNERS File third_party/freetype-android/OWNERS (right): https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/OWNERS#newcode2 third_party/freetype-android/OWNERS:2: michaelbai@chromium.org Please add ...
5 years, 6 months ago (2015-06-03 03:30:35 UTC) #11
brettw
LGTM https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/README.chromium File third_party/freetype-android/README.chromium (right): https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/README.chromium#newcode7 third_party/freetype-android/README.chromium:7: Security Critical: no Non-blocking this CL since you're ...
5 years, 6 months ago (2015-06-03 04:34:59 UTC) #12
bungeman-chromium
https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/OWNERS File third_party/freetype-android/OWNERS (right): https://codereview.chromium.org/1155743013/diff/20001/third_party/freetype-android/OWNERS#newcode2 third_party/freetype-android/OWNERS:2: michaelbai@chromium.org On 2015/06/03 03:30:35, Xianzhu wrote: > Please add ...
5 years, 6 months ago (2015-06-03 12:41:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155743013/60001
5 years, 6 months ago (2015-06-03 12:41:53 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-03 15:41:32 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 15:42:32 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7ffe490b7c43e2f9393caf283d809c1983bbeb3e
Cr-Commit-Position: refs/heads/master@{#332616}

Powered by Google App Engine
This is Rietveld 408576698