extensions/browser/api/device_permissions_prompt.cc - Issue 1155743003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_prompt.cc

Issue 1155743003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/device_permissions_prompt.cc

diff --git a/extensions/browser/api/device_permissions_prompt.cc b/extensions/browser/api/device_permissions_prompt.cc

index b2df4726b2591a0771d6c0f4e2c2e4efb1e0dc31..90ef28d7caf1d2cd8b843ff616a8dd62d83b9954 100644

--- a/extensions/browser/api/device_permissions_prompt.cc

+++ b/extensions/browser/api/device_permissions_prompt.cc

@@ -334,7 +334,7 @@ void DevicePermissionsPrompt::Prompt::AddCheckedDevice(

scoped_ptr<DeviceInfo> device,

bool allowed) {

if (allowed) {

- devices_.push_back(device.release());

+ devices_.push_back(device.Pass());

if (observer_) {

observer_->OnDevicesChanged();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »