Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: tools/gn/command_format.cc

Issue 1155713006: GN: Make file/dir resolving return errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/action_target_generator.cc ('k') | tools/gn/commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_format.cc
diff --git a/tools/gn/command_format.cc b/tools/gn/command_format.cc
index 7aa8749748bb371d8b54ca0c64dc3cb6cbed9067..a8143ffb8eb24585c35a8481638bb1ae39dfe109 100644
--- a/tools/gn/command_format.cc
+++ b/tools/gn/command_format.cc
@@ -1012,7 +1012,14 @@ int RunFormat(const std::vector<std::string>& args) {
Setup setup;
SourceDir source_dir =
SourceDirForCurrentDirectory(setup.build_settings().root_path());
- SourceFile file = source_dir.ResolveRelativeFile(args[0]);
+
+ Err err;
+ SourceFile file = source_dir.ResolveRelativeFile(Value(nullptr, args[0]),
+ &err);
+ if (err.has_error()) {
+ err.PrintToStdout();
+ return 1;
+ }
std::string output_string;
if (FormatFileToString(&setup, file, dump_tree, &output_string)) {
« no previous file with comments | « tools/gn/action_target_generator.cc ('k') | tools/gn/commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698