content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_request_util.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

index 1e678cccac25fbc97fd178fd7531b627020cb509..62ad605ee65b33aaaa26a756ce006a6fa6b69daa 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java

@@ -94,10 +94,10 @@ class WebContentsObserverProxy extends WebContentsObserver {

@Override

@CalledByNative

public void didFailLoad(boolean isProvisionalLoad, boolean isMainFrame, int errorCode,

- String description, String failingUrl) {

+ String description, String failingUrl, boolean wasIgnoredByHandler) {

for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {

- mObserversIterator.next().didFailLoad(

- isProvisionalLoad, isMainFrame, errorCode, description, failingUrl);

+ mObserversIterator.next().didFailLoad(isProvisionalLoad, isMainFrame, errorCode,

+ description, failingUrl, wasIgnoredByHandler);

}