content/common/frame_messages.h - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_request_util.cc ('K') | « content/child/web_url_request_util.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 65750d7799689da1fe7ab249f23bc9b80eb31ef5..d0b03feb34e45b513608bb60695fe8b9cffe89e3 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -118,6 +118,7 @@ IPC_STRUCT_BEGIN(FrameHostMsg_DidFailProvisionalLoadWithError_Params)

// True if the failure is the result of navigating to a POST again

// and we're going to show the POST interstitial.

IPC_STRUCT_MEMBER(bool, showing_repost_interstitial)

+ IPC_STRUCT_MEMBER(bool, was_ignored_by_handler)

IPC_STRUCT_END()

IPC_STRUCT_TRAITS_BEGIN(content::FrameNavigateParams)

@@ -675,10 +676,11 @@ IPC_MESSAGE_ROUTED1(FrameHostMsg_DidCommitProvisionalLoad,

// Notifies the browser that a document has been loaded.

IPC_MESSAGE_ROUTED0(FrameHostMsg_DidFinishDocumentLoad)

-IPC_MESSAGE_ROUTED3(FrameHostMsg_DidFailLoadWithError,

+IPC_MESSAGE_ROUTED4(FrameHostMsg_DidFailLoadWithError,

GURL /* validated_url */,

int /* error_code */,

- base::string16 /* error_description */)

+ base::string16 /* error_description */,

+ bool /* was_ignored_by_handler */)

// Sent when the renderer decides to ignore a navigation.

IPC_MESSAGE_ROUTED0(FrameHostMsg_DidDropNavigation)