content/browser/frame_host/navigator.h - Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator.h

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/renderer/aw_content_renderer_client.cc ('K') | « content/browser/android/web_contents_observer_proxy.cc ('k') | content/browser/frame_host/navigator_delegate.h » ('j') | content/child/web_url_request_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator.h

diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h

index 986f73182ea809214188da21bafe50b8c077cc70..b809629a2d7013625fb4a8652ba5ac3ac9a489ff 100644

--- a/content/browser/frame_host/navigator.h

+++ b/content/browser/frame_host/navigator.h

@@ -65,7 +65,8 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {

RenderFrameHostImpl* render_frame_host,

const GURL& url,

int error_code,

- const base::string16& error_description) {}

+ const base::string16& error_description,

+ bool was_ignored_by_handler) {}

// The RenderFrameHostImpl has committed a navigation.

virtual void DidNavigate(