Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2435)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag showing that shouldOverrideUrl cancelled the navigation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index 548d3ecb1b05fcbff5a633e28d748a3461612ec5..1afa88afa79651bdb29757ef5f7728591ddd9142 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -106,7 +106,8 @@ bool AwContentRendererClient::HandleNavigation(
// use NavigationInterception throttle to handle the call as that can
// be deferred until after the java side has been constructed.
- if (opener_id != MSG_ROUTING_NONE) {
+ return false; // don't call shouldOverrideUrlLoading from this function...
+ /*if (opener_id != MSG_ROUTING_NONE) {
return false;
}
@@ -116,7 +117,7 @@ bool AwContentRendererClient::HandleNavigation(
int render_frame_id = render_frame->GetRoutingID();
RenderThread::Get()->Send(new AwViewHostMsg_ShouldOverrideUrlLoading(
render_frame_id, url, &ignore_navigation));
- return ignore_navigation;
+ return ignore_navigation;*/
}
void AwContentRendererClient::RenderFrameCreated(

Powered by Google App Engine
This is Rietveld 408576698