Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2316)

Unified Diff: android_webview/native/aw_contents_client_bridge.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix qinmin nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents_client_bridge.cc
diff --git a/android_webview/native/aw_contents_client_bridge.cc b/android_webview/native/aw_contents_client_bridge.cc
index 2b16fcc89614becab919eee98bdd14be40b1814d..9e570af6761308a0efd7d293ce26c41705c4701a 100644
--- a/android_webview/native/aw_contents_client_bridge.cc
+++ b/android_webview/native/aw_contents_client_bridge.cc
@@ -340,20 +340,6 @@ void AwContentsClientBridge::RunBeforeUnloadDialog(
env, obj.obj(), jurl.obj(), jmessage.obj(), callback_id);
}
-bool AwContentsClientBridge::ShouldOverrideUrlLoading(
- const base::string16& url, bool has_user_gesture, bool is_redirect) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (obj.is_null())
- return false;
- ScopedJavaLocalRef<jstring> jurl = ConvertUTF16ToJavaString(env, url);
- devtools_instrumentation::ScopedEmbedderCallbackTask(
- "shouldOverrideUrlLoading");
- return Java_AwContentsClientBridge_shouldOverrideUrlLoading(
- env, obj.obj(),
- jurl.obj(), has_user_gesture, is_redirect);
-}
-
void AwContentsClientBridge::ConfirmJsResult(JNIEnv* env,
jobject,
int id,
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.h ('k') | android_webview/renderer/aw_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698