Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 1155713005: Use a resource throttle to implement shouldOverrideUrlLoading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix qinmin nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_client_bridge_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index ca277be7d280e5213f843835094a09ae530c0794..87a1b932882e6235414e619b61b32cd11766cb2e 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -24,7 +24,6 @@
#include "components/cdm/browser/cdm_message_filter_android.h"
#include "content/public/browser/access_token_store.h"
#include "content/public/browser/browser_message_filter.h"
-#include "content/public/browser/browser_thread.h"
#include "content/public/browser/child_process_security_policy.h"
#include "content/public/browser/client_certificate_delegate.h"
#include "content/public/browser/render_frame_host.h"
@@ -39,7 +38,6 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/resources/grit/ui_resources.h"
-using content::BrowserThread;
using content::ResourceType;
namespace android_webview {
@@ -53,15 +51,8 @@ public:
explicit AwContentsMessageFilter(int process_id);
// BrowserMessageFilter methods.
- void OverrideThreadForMessage(const IPC::Message& message,
- BrowserThread::ID* thread) override;
bool OnMessageReceived(const IPC::Message& message) override;
- void OnShouldOverrideUrlLoading(int routing_id,
- const base::string16& url,
- bool has_user_gesture,
- bool is_redirect,
- bool* ignore_navigation);
void OnSubFrameCreated(int parent_render_frame_id, int child_render_frame_id);
private:
@@ -80,43 +71,15 @@ AwContentsMessageFilter::AwContentsMessageFilter(int process_id)
AwContentsMessageFilter::~AwContentsMessageFilter() {
}
-void AwContentsMessageFilter::OverrideThreadForMessage(
- const IPC::Message& message, BrowserThread::ID* thread) {
- if (message.type() == AwViewHostMsg_ShouldOverrideUrlLoading::ID) {
- *thread = BrowserThread::UI;
- }
-}
-
bool AwContentsMessageFilter::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(AwContentsMessageFilter, message)
- IPC_MESSAGE_HANDLER(AwViewHostMsg_ShouldOverrideUrlLoading,
- OnShouldOverrideUrlLoading)
IPC_MESSAGE_HANDLER(AwViewHostMsg_SubFrameCreated, OnSubFrameCreated)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
}
-void AwContentsMessageFilter::OnShouldOverrideUrlLoading(
- int render_frame_id,
- const base::string16& url,
- bool has_user_gesture,
- bool is_redirect,
- bool* ignore_navigation) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- *ignore_navigation = false;
- AwContentsClientBridgeBase* client =
- AwContentsClientBridgeBase::FromID(process_id_, render_frame_id);
- if (client) {
- *ignore_navigation =
- client->ShouldOverrideUrlLoading(url, has_user_gesture, is_redirect);
- } else {
- LOG(WARNING) << "Failed to find the associated render view host for url: "
- << url;
- }
-}
-
void AwContentsMessageFilter::OnSubFrameCreated(int parent_render_frame_id,
int child_render_frame_id) {
AwContentsIoThreadClient::SubFrameCreated(
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_client_bridge_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698