Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: content/browser/devtools/worker_devtools_agent_host.h

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/worker_devtools_agent_host.h
diff --git a/content/browser/devtools/worker_devtools_agent_host.h b/content/browser/devtools/worker_devtools_agent_host.h
index 30fee5a6211a5dd231afbea18c25baa50faa66a1..d252f56c4a6e0f97c365a24458a2a3a0d1511450 100644
--- a/content/browser/devtools/worker_devtools_agent_host.h
+++ b/content/browser/devtools/worker_devtools_agent_host.h
@@ -5,7 +5,7 @@
#ifndef CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_AGENT_HOST_H_
#define CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_AGENT_HOST_H_
-#include "content/browser/devtools/ipc_devtools_agent_host.h"
+#include "content/browser/devtools/devtools_agent_host_impl.h"
#include "ipc/ipc_listener.h"
namespace content {
@@ -13,7 +13,7 @@ namespace content {
class BrowserContext;
class SharedWorkerInstance;
-class WorkerDevToolsAgentHost : public IPCDevToolsAgentHost,
+class WorkerDevToolsAgentHost : public DevToolsAgentHostImpl,
public IPC::Listener {
public:
typedef std::pair<int, int> WorkerId;
@@ -21,11 +21,10 @@ class WorkerDevToolsAgentHost : public IPCDevToolsAgentHost,
// DevToolsAgentHost override.
BrowserContext* GetBrowserContext() override;
- // IPCDevToolsAgentHost implementation.
- void SendMessageToAgent(IPC::Message* message) override;
+ // DevToolsAgentHostImpl overrides.
void Attach() override;
- void OnClientAttached(bool reattached) override;
- void OnClientDetached() override;
+ void Detach() override;
+ bool DispatchProtocolMessage(const std::string& message) override;
// IPC::Listener implementation.
bool OnMessageReceived(const IPC::Message& msg) override;
@@ -50,16 +49,17 @@ class WorkerDevToolsAgentHost : public IPCDevToolsAgentHost,
WORKER_PAUSED_FOR_REATTACH,
};
- void AttachToWorker();
- void DetachFromWorker();
- void WorkerCreated();
- void OnDispatchOnInspectorFrontend(const DevToolsMessageChunk& message);
-
+ virtual void OnAttachedStateChanged(bool attached);
const WorkerId& worker_id() const { return worker_id_; }
private:
friend class SharedWorkerDevToolsManagerTest;
+ void AttachToWorker();
+ void DetachFromWorker();
+ void WorkerCreated();
+ void OnDispatchOnInspectorFrontend(const DevToolsMessageChunk& message);
+
WorkerState state_;
WorkerId worker_id_;
DISALLOW_COPY_AND_ASSIGN(WorkerDevToolsAgentHost);
« no previous file with comments | « content/browser/devtools/service_worker_devtools_manager.cc ('k') | content/browser/devtools/worker_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698